Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd setting to throw exception in non-interactive mode if some params are missing #64
Conversation
|
@stof any chance that this PR would be reviewed? |
fduch
force-pushed the
fduch:exception-if-missing
branch
2 times, most recently
from
9122b11
to
d662982
* exception-if-missing: add setting to throw exception in non-interactive mode if some params are missing
|
+1 for such a functionality |
|
@ZeeCoder since @stof didn't give any feedback to this PR i use exception-if-missing branch in my fork of the official repository without any issues for almost a year.. :) |
|
+1 , but:
Manage fine without this making sure params have sensible defaults. |
|
+1 Merging this PR would solve a lot of issues we have with our continuous integration. |
|
|
|
@stof Can we help you reviewing this PR? It'd be indeed really helpful. Thanks. |
fduch
force-pushed the
fduch:exception-if-missing
branch
2 times, most recently
from
debbb26
to
d662982
This PR covers #63 and provides new
exception-if-missingconfiguration option.By default the behavior of script handler is the same as current. But when
exception-if-missingoption is set totrueParameterHandler will throw an exception when some parameters are missing. This is very useful during build/deploy process (executed for example on build/ci servers) when it is needed only to validateparameters.ymlfile before installing the application and abort the process when something went wrong, but not to change it's original content in any way.This behavior affects only non-interactive mode.