Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3: Allow scalar values #16

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@pl12133
Copy link

@pl12133 pl12133 commented May 21, 2018

Hey @developit, hope you are doing well!

Fixes #3

Old gzip size: 305B
New gzip size: 308B (+3B)

This adds a guard against undefined event.target and this in linkState callback. This causes a scalar value to pass through instead of blowing up when accessing nodeName on undefined.

Let me know what you think, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.