Skip to content

/ libnetwork

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: github.com/armon/go-radix v1.0.0 #2581

Open
wants to merge 2 commits into
base: master
from
Open

vendor: github.com/armon/go-radix v1.0.0 #2581

wants to merge 2 commits into from
+1,633 −543

Conversation

@thaJeztah
Copy link
Member

thaJeztah commented Sep 11, 2020

full diff: armon/go-radix@e39d623...v1.0.0
@thaJeztah
vendor: github.com/armon/go-radix v1.0.0
Verified
This commit was signed with a verified signature.
thaJeztah Sebastiaan van Stijn
GPG key ID: 76698F39D527CE8C Learn about signing commits
Loading status checks…
31a972d 
full diff: armon/go-radix@e39d623...v1.0.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 11, 2020

Ah, "nice" ...

=== RUN   TestNetworkDBCRUDTableEntries
2020/09/11 15:11:30 Closing DB instances...
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x917796]

goroutine 292 [running]:
github.com/docker/libnetwork/vendor/github.com/armon/go-radix.recursiveWalk(0x0, 0xc000050b50, 0xc000248800)
	/go/src/github.com/docker/libnetwork/vendor/github.com/armon/go-radix/radix.go:519 +0x26
github.com/docker/libnetwork/vendor/github.com/armon/go-radix.recursiveWalk(0xc0003a0bd0, 0xc000050b50, 0xc000050b40)
	/go/src/github.com/docker/libnetwork/vendor/github.com/armon/go-radix/radix.go:525 +0x7e
github.com/docker/libnetwork/vendor/github.com/armon/go-radix.recursiveWalk(0xc0003a0b10, 0xc000050b50, 0xc00034e950)
	/go/src/github.com/docker/libnetwork/vendor/github.com/armon/go-radix/radix.go:525 +0x7e
github.com/docker/libnetwork/vendor/github.com/armon/go-radix.recursiveWalk(0xc0003283f0, 0xc000050b50, 0x1)
	/go/src/github.com/docker/libnetwork/vendor/github.com/armon/go-radix/radix.go:525 +0x7e
github.com/docker/libnetwork/vendor/github.com/armon/go-radix.(*Tree).Walk(...)
	/go/src/github.com/docker/libnetwork/vendor/github.com/armon/go-radix/radix.go:447
github.com/docker/libnetwork/networkdb.(*NetworkDB).deleteNodeTableEntries(0xc0001e6ea0, 0xc00047c930, 0xc)
	/go/src/github.com/docker/libnetwork/networkdb/networkdb.go:546 +0xa3
github.com/docker/libnetwork/networkdb.(*NetworkDB).changeNodeState(0xc0001e6ea0, 0xc00047c930, 0xc, 0x1, 0xc000080570, 0xc000328301, 0xc000025ac6)
	/go/src/github.com/docker/libnetwork/networkdb/nodemgmt.go:88 +0x31e
github.com/docker/libnetwork/networkdb.(*NetworkDB).handleNodeEvent(0xc0001e6ea0, 0xc000234e80, 0x0)
	/go/src/github.com/docker/libnetwork/networkdb/delegate.go:60 +0x1ad
github.com/docker/libnetwork/networkdb.(*NetworkDB).handleNodeMessage(0xc0001e6ea0, 0xc000025ac0, 0x12, 0x20)
	/go/src/github.com/docker/libnetwork/networkdb/delegate.go:299 +0x121
github.com/docker/libnetwork/networkdb.(*NetworkDB).handleMessage(0xc0001e6ea0, 0xc00051a006, 0x16, 0xfffa, 0xc0003a6500)
	/go/src/github.com/docker/libnetwork/networkdb/delegate.go:383 +0x2dc
github.com/docker/libnetwork/networkdb.(*delegate).NotifyMsg(0xc000010540, 0xc00051a006, 0x16, 0xfffa)
	/go/src/github.com/docker/libnetwork/networkdb/delegate.go:402 +0x72
github.com/docker/libnetwork/vendor/github.com/hashicorp/memberlist.(*Memberlist).handleUser(...)
	/go/src/github.com/docker/libnetwork/vendor/github.com/hashicorp/memberlist/net.go:550
github.com/docker/libnetwork/vendor/github.com/hashicorp/memberlist.(*Memberlist).packetHandler(0xc0000c2500)
	/go/src/github.com/docker/libnetwork/vendor/github.com/hashicorp/memberlist/net.go:390 +0x18e
created by github.com/docker/libnetwork/vendor/github.com/hashicorp/memberlist.newMemberlist
	/go/src/github.com/docker/libnetwork/vendor/github.com/hashicorp/memberlist/memberlist.go:180 +0x406
exit status 2
FAIL	github.com/docker/libnetwork/networkdb	13.464s
make: *** [Makefile:129: unit-tests-local] Error 1
make: *** [Makefile:123: unit-tests] Error 2
@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 11, 2020

Ah, looks like @SamWhited had a patch for that; armon/go-radix#12
@thaJeztah thaJeztah mentioned this pull request Sep 11, 2020
Open
@thaJeztah
[TEST] Use immutable radix
Verified
This commit was signed with a verified signature.
thaJeztah Sebastiaan van Stijn
GPG key ID: 76698F39D527CE8C Learn about signing commits
Loading status checks…
9f22563 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the thaJeztah:update_radix branch from 0644f26 to 9f22563 Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@thaJeztah
You can’t perform that action at this time.