Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upelasticsearch: don't json load doc id on failure #50
Conversation
foklepoint
requested review from
dellis23 and
spladug
and removed request for
spladug and
dellis23
This addresses the issue where ES would be down and not return a doc id, but we still attempted to read the returned response even though the response code was not valid
|
|
|
er, yeah, that makes more sense :P |
|
whoops, yup |
|
My understanding of the issue is that Elasticsearch is hanging until a gateway timeout happens. This would fix the crash after the timeout but it'll still hang for a long time. |
In cases where we can't load the deploy annotation id (i.e when ES returns a bad response), we may refer to this deploy_annotation_id, which will cause exceptions if it isn't set. Previously it was being set in elasticsearch.on_deploy_start
This is indeed true :) |
|
|
|
Couldn't find an easy way to adjust the timeout of reactor for ES :/ |
|
In our version of twisted the way to do a timeout is to do |
|
seems fine but timeouts would be nice |
This addresses the issue where ES would be down and
not return a doc id, but we still attempted to read
the returned response even though the response code
was not valid