JS function parameter for backend configuration #48

hedav85 · 2016-01-07T16:18:40Z

For different backends I have definded JS-functions. This functions are called with two parameters:

req.backend = _.find(config.backend, function(server) {
          if (server.pattern) { return new RegExp(server.pattern).test(req.url); }
          if (server.fn) {
            if (typeof config.functions[server.fn] == 'function') {
              return config.functions[server.fn](req, req.templateVars);
            }
          }
      });

For my situation it would be good to have the current config also as a parameter.

return config.functions[server.fn](req, req.templateVars, server);

Then it is possible for me to add own configurations and to check against them in my JS-function.

What do you think about it?

cliftonc · 2016-01-07T17:14:57Z

Definitely - its a good idea, and an oversight really. Are you able to submit a PR?

hedav85 · 2016-01-08T08:25:14Z

Yes I'll submit a PR in the next days.

cliftonc · 2018-01-12T14:40:46Z

@sithmel we should do this.

cliftonc added the enhancement label Jan 12, 2018

tes / compoxure

JS function parameter for backend configuration #48

JS function parameter for backend configuration #48

hedav85 commented Jan 7, 2016

cliftonc commented Jan 7, 2016

hedav85 commented Jan 8, 2016

cliftonc commented Jan 12, 2018

tes / compoxure

JS function parameter for backend configuration #48

JS function parameter for backend configuration #48

Comments

hedav85 commented Jan 7, 2016

cliftonc commented Jan 7, 2016

hedav85 commented Jan 8, 2016

cliftonc commented Jan 12, 2018