Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add regression test #1051
Draft
Add regression test #1051
Conversation
|
I think Sentry is creating a FatalErrorException for E_COMPILE_WARNING (and E_CORE_WARNING) because an error handler function cannot handle these error types. I don't think it should though, as these are by definition not fatal errors, so it just creates confusion for the user. |
|
By the way, this error is also captured by Sentry 1.x, but as an ErrorException with level "warning", rather than a FatalErrorException with level "fatal". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is just a regression test. I may not have the time to fix it, feel free to push it forward.