Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix keyboard control for null step with marks #607
Conversation
calculateNextValue incorrectly returns mark object instead of value when steps are disabled
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
======================================
Coverage 95.4% 95.4%
======================================
Files 2 2
Lines 87 87
Branches 29 29
======================================
Hits 83 83
Misses 4 4
Continue to review full report at Codecov.
|
weijiangan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Currently,
util.calculateNextValue()incorrectly returns mark object instead of value when steps are disabled (by passingnulltostepprop) and marks are usedThe consequence of this is keyboard navigation will crash the slider due to unhandled errors that stem from unexpected value type.
Steps to reproduce
step = {null}as prop to slider component