Skip to content

/ java-recommender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete Quickstart for v1beta1 library #306

Open
wants to merge 1 commit into
base: master
from
Open

Remove obsolete Quickstart for v1beta1 library #306

wants to merge 1 commit into from

Conversation

@jpatokal
Copy link

@jpatokal jpatokal commented Oct 20, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️
@jpatokal
Remove obsolete Quickstart for v1beta1 library
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
41a9b34
@jpatokal jpatokal requested a review from googleapis/yoshi-java as a code owner Oct 20, 2020
@google-cla google-cla bot added the cla: yes label Oct 20, 2020
@codecov
Copy link

@codecov codecov bot commented Oct 20, 2020 •
edited

Codecov Report

Merging #306 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #306   +/-   ##
=========================================
  Coverage     73.10%   73.10%           
  Complexity      150      150           
=========================================
  Files            12       12           
  Lines          1212     1212           
  Branches         21       21           
=========================================
  Hits            886      886           
  Misses          301      301           
  Partials         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c85285...41a9b34. Read the comment docs.
@chingor13
chingor13 requested changes Nov 2, 2020
View changes
README.md
@@ -93,7 +93,6 @@ has instructions for running the samples.

| Sample | Source Code | Try it |
| --------------------------- | --------------------------------- | ------ |
| List Recommendations | [source code](https://github.com/googleapis/java-recommender/blob/master/samples/generated/src/main/java/com/google/cloud/examples/recommender/v1beta1/SampleListRecommendations.java) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/java-recommender&page=editor&open_in_editor=samples/generated/src/main/java/com/google/cloud/examples/recommender/v1beta1/SampleListRecommendations.java) |

This comment has been minimized.

Sign in to view
@chingor13

chingor13 Nov 2, 2020
Collaborator

This file is generated. If we actually want to delete this entry, we need to delete the sample in the link and automation can remove this from the README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
api: recommender cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jpatokal @chingor13
You can’t perform that action at this time.