Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub auth #2160

Draft
wants to merge 3 commits into
base: master
from
Draft

Fix GitHub auth #2160

wants to merge 3 commits into from

Conversation

@code-asher
Copy link
Collaborator

@code-asher code-asher commented Oct 5, 2020

  • Fix the callback URI
  • This needs to match the URI in the oauth app
  • Fix manual token entry
    • Currently it just errors with "network error"
  • Fix final redirect
  • Might need to create our own oauth application to get this working due to VS Code using a scheme we can't use (vscode://).

Closes #1883
Closes #2253

code-asher added 2 commits Sep 10, 2020
@code-asher code-asher force-pushed the github-auth branch from cd700cd to fe9e54a Oct 5, 2020
@code-asher code-asher force-pushed the github-auth branch from fe9e54a to 9fa6f74 Oct 5, 2020
Base automatically changed from vscode-1.49.0 to master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.