Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky sequential/test-fs-watch #36249

Merged
merged 1 commit into from Nov 27, 2020
Merged

test: fix flaky sequential/test-fs-watch #36249

merged 1 commit into from Nov 27, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 24, 2020

Fixes: #36247

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Nov 24, 2020
@Trott Trott added flaky-test request-ci labels Nov 24, 2020
@github-actions github-actions bot removed the request-ci label Nov 24, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34540/

@Trott
Copy link
Member Author

@Trott Trott commented Nov 24, 2020

Stress test: https://ci.nodejs.org/job/node-stress-single-test/206/

@Trott
Copy link
Member Author

@Trott Trott commented Nov 24, 2020

I ran tools/test.py --repeat 1000 ./node test/sequential/test-fs-watch.js locally on master and on this PR. Master failed 4 times. This PR had no failures.

@Trott
Copy link
Member Author

@Trott Trott commented Nov 25, 2020

Stress test: https://ci.nodejs.org/job/node-stress-single-test/206/

So this fixes the existing flakiness but introduces a different problem in that now it sometimes fails because it gets a rename event rather than a change event. That's another OS-specific weirdness thing but I'll see if we can get it to be consistently change.

@Trott
Copy link
Member Author

@Trott Trott commented Nov 25, 2020

Stress test: https://ci.nodejs.org/job/node-stress-single-test/207/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 25, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34545/

@Trott
Copy link
Member Author

@Trott Trott commented Nov 25, 2020

That's another OS-specific weirdness thing but I'll see if we can get it to be consistently change.

The fixup commit fixed it locally and on CI.

@Trott
test: fix flaky sequential/test-fs-watch
8ba65b5 
Fixes: nodejs#36247

PR-URL: nodejs#36249
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
Copy link
Member Author

@Trott Trott commented Nov 27, 2020

Landed in 8ba65b5

@Trott Trott merged commit 8ba65b5 into nodejs:master Nov 27, 2020
28 of 30 checks passed
@Trott Trott deleted the watch-interval branch Nov 27, 2020
danielleadams pushed a commit that referenced this issue Dec 7, 2020
@Trott @danielleadams
test: fix flaky sequential/test-fs-watch
2c7358e 
Fixes: #36247

PR-URL: #36249
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
targos pushed a commit that referenced this issue May 1, 2021
@Trott @targos
test: fix flaky sequential/test-fs-watch
b11e3ea 
Fixes: #36247

PR-URL: #36249
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung

@aduh95 aduh95

Assignees
No one assigned
Labels
flaky-test test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate flaky sequential/test-fs-watch
4 participants
@Trott @nodejs-github-bot @joyeecheung @aduh95