Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Monitoring section to the list #44
Conversation
Add Monitoring session.
| - [ ] Use centralized loggins for all services and components. | ||
| - [ ] Use agents to monitoring all trafic, errors, requests and responses. | ||
| - [ ] Use alerts for SMS, Slack, Email, Telegram, Kibana, Cloudwatch e etc. | ||
| - [ ] Check if you don't log sensetive data like Credid Cards, Passwords and PIN's. |
roffel
Jul 26, 2017
•
Credid should be Credit :-) . And I think that sensetive should be sensitive
Credid should be Credit :-) . And I think that sensetive should be sensitive
kenguest
Jul 26, 2017
also; logins or log-ins... and "PINs" not "PIN's".
also; logins or log-ins... and "PINs" not "PIN's".
|
@netcode Aside from the points raised by the reviewers above (all good points worth addressing!), any thoughts about this PR? Should we accept (pending the corrections mentioned above) or just close this, or were we waiting for something else (more discussion, etc)? |
|
It does add value, so I'd be inclined to accept/merge the PR; additional changes/tweaks can always be merged in via another PR. |
|
Done. Thanks for help! |
| @@ -61,10 +61,10 @@ Checklist of the most important security countermeasures when designing, testing | |||
| - [ ] Design a rollback solution for deployments. | |||
|
|
|||
| ## Monitoring | |||
| - [ ] Use centralized loggins for all services and components. | |||
| - [ ] Use centralized log-ins for all services and components. | |||
| - [ ] Use agents to monitoring all trafic, errors, requests and responses. | |||
othyn
Nov 16, 2017
•
monitoring
Should be monitor.
trafic
Should be traffic.
Should read:
Use agents to monitor all traffic, errors, requests and responses.
👍
monitoring
Should be monitor.
trafic
Should be traffic.
Should read:
Use agents to monitor all traffic, errors, requests and responses.
| @@ -61,10 +61,10 @@ Checklist of the most important security countermeasures when designing, testing | |||
| - [ ] Design a rollback solution for deployments. | |||
|
|
|||
| ## Monitoring | |||
| - [ ] Use centralized loggins for all services and components. | |||
| - [ ] Use centralized log-ins for all services and components. | |||
| - [ ] Use agents to monitoring all trafic, errors, requests and responses. | |||
| - [ ] Use alerts for SMS, Slack, Email, Telegram, Kibana, Cloudwatch e etc. | |||
othyn
Nov 16, 2017
Should read:
Use alerts for SMS, Slack, Email, Telegram, Kibana, Cloudwatch, etc.
Extra e is not required and as there is no conjunction after etc it should have a comma preceding it.
👍
Should read:
Use alerts for SMS, Slack, Email, Telegram, Kibana, Cloudwatch, etc.
Extra e is not required and as there is no conjunction after etc it should have a comma preceding it.
| - [ ] Use agents to monitoring all trafic, errors, requests and responses. | ||
| - [ ] Use alerts for SMS, Slack, Email, Telegram, Kibana, Cloudwatch e etc. | ||
| - [ ] Check if you don't log sensetive data like Credid Cards, Passwords and PIN's. | ||
| - [ ] Check if you don't log sensitive data like Credit Cards, Passwords and PINs. | ||
| - [ ] Use an IDS or/and IPS system to monitoring your API requests and instances. |
othyn
Nov 16, 2017
Just a few little grammatical changes:
Use an IDS (Intrusion Detection System) and/or IPS (Intrusion Prevention System) for monitoring your API requests and instances
Your choice whether to include the acronym descriptions, just thought it may be helpful :)
Just a few little grammatical changes:
Use an IDS (Intrusion Detection System) and/or IPS (Intrusion Prevention System) for monitoring your API requests and instances
Your choice whether to include the acronym descriptions, just thought it may be helpful :)
| - [ ] Use agents to monitoring all trafic, errors, requests and responses. | ||
| - [ ] Use alerts for SMS, Slack, Email, Telegram, Kibana, Cloudwatch e etc. | ||
| - [ ] Check if you don't log sensetive data like Credid Cards, Passwords and PIN's. | ||
| - [ ] Check if you don't log sensitive data like Credit Cards, Passwords and PINs. |
othyn
Nov 16, 2017
This may read more fluidly:
Check that you aren't logging sensitive data like Credit Cards, Passwords and PINs.
I may be getting a little picky... haha
This may read more fluidly:
Check that you aren't logging sensitive data like Credit Cards, Passwords and PINs.
I may be getting a little picky... haha
|
Will |
Add Monitoring session.