jonahwilliams
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign upPinned
3,766 contributions in the last year
Contribution activity
November 2020
Created 84 commits in 5 repositories
Created a pull request in flutter/flutter that received 5 comments
[devicelab] update hot reload benchmark to be more representative
Description For more background see go/flutter-2020-hot-reload This updates the hot reload benchmark to include additional measurements for: mediu…
+128
−71
•
5
comments
Opened 99 other pull requests in 5 repositories
flutter/flutter
75
merged
4
open
14
closed
- [flutter_tools] fix port leak in flutter_driver
- [flutter_tools] Remove usage of --precompiled flag for web tests
- [flutter_tools] support canvaskit unit testing on web
- [flutter_tools] catch FormatException also
- [devicelab] don't use set modified for hot reload bench
- only use code single path for verification of target file existence
- [flutter_tools] delete BuildRunnerWebCompilationProxy and WebCompilationProxy
- [flutter_tools] disable SWR optimization on dev
- [flutter_tools] share bootstrap module between run and test
- Revert "[flutter_tools] wire up alternative invalidation strategy to features"
- [flutter_tools] wire up alternative invalidation strategy to features
- [flutter_tools] remove globals from flutter web platform
- [flutter_tools] skip ck restart on all platforms
- Revert "Stop extra framework copy during build ios-framework"
- [flutter_tools] run web unit tests in sound null safety
- [flutter_tools] update dependencies
- [flutter_tools] refactor shared memory filesystem logic
- [flutter_tools] add support for dart defines to flutter test
- switch to flutter test everywhere
- [flutter_tools] display message for current null safety mode
- [flutter_tools] use frontend_server for web test compilation
- [flutter_tools] remove globals from features
- [flutter_tools] reduce build bundle API
- [flutter_tools] stop unit from writing real file
- [flutter_tools] remove unused/deprecated asset parameters
- Some pull requests not shown.
flutter/engine
1
closed
2
merged
google/process.dart
1
merged
google/file.dart
1
merged
google/platform.dart
1
merged
Reviewed 90 pull requests in 5 repositories
flutter/flutter 80 pull requests
- [flutter_tools] Don't fail copying files if the destination is not writable
- [flutter_tools] Display "no platforms" message based on results when creating plugins project
- Wait for Android plugin to load before configuring plugin dependency
- Uncomment build_ios_framework_module_test tmp cleanup
- only use code single path for verification of target file existence
- flutter_tools: refactor `CreateCommand`.
- [flutter_tools] deploy version.json asset on Linux
- [flutter_tools] delete BuildRunnerWebCompilationProxy and WebCompilationProxy
- [flutter_tools] share bootstrap module between run and test
- Remove deprecated 'flutter build aot'
- Fix error message typo
- [flutter_tools] Treat public_member_api_docs similar to others linter output
- [flutter_test] Correct flutter_test_configuration.dart documentation
- Ensure attaching to an application with an existing DDS instance is not treated as a fatal error
- Run module tests on try builders when flutter_tools changes
- Ensure attaching to an application with an existing DDS instance is not treated as a fatal error
- [flutter_tools] use frontend_server for web test compilation
- Stop extra framework copy during build ios-framework
- [flutter_tools] add support for dart defines to flutter test
- Force regeneration of old Podfile
- Add extra Flutter settings to ios_app_with_extensions Podfile
- Point to a new artifacts location.
- Roll package:dds to 1.5.1 and add isCompleted guards around completers in base/dds.dart
- [devicelab] LUCI builder flag
- fix and re-enable roll_dev_integration test
- Some pull request reviews not shown.
flutter/engine 7 pull requests
flutter/cocoon 1 pull request
dart-lang/webdev 1 pull request
google/flutter-desktop-embedding 1 pull request
Created an issue in flutter/flutter that received 12 comments
pub null-safety analysis fails on sky_engine
jonahwilliams-macbookpro2:flutter jonahwilliams$ flutter pub get
Downloading package sky_engine... 344ms
Downloading flutter_patched_sdk tools... 7…
12
comments
Opened 35 other issues in 5 repositories
flutter/flutter
15
open
16
closed
- RenderAnimatedOpacityMixin causes child pixel snapping when fully opaque
- android_plugin_example_app_build_test is unnecessarily reserving a devicelab android device
- Unhandled exception in long running web tests shard
- Update messaging about web stability during flutter run
- Run flutter web unit tests in sound mode
- Update hot reload benchmarks to better reflect average workloads
- Simplify the flutter_web_plugins plugin registration API broke the analyzer benchmark
- Flake in web integration test shard
- Reverted [integration_test] Add a `run` method for proper reporting of test results
- Update to metrics center broke analysis CI
- Remove automatic `flutter doctor` run during `flutter create`
- Would like the dashboard to surface infra failures as purple and not close the tree
- mac_build_test infra failures are keeping tree closed
- Using absolute URI for web crashes dart compiler if it is a linux style path
- Catalina tests have closed the tree due to missing device
- Android crash on multi_widget_construction_perf__timeline_summary
- pub get slows down dramatically after updating package to null safety
- Addition of space to SDK checkout broke linux build tests
- Crash in animated placeholder perf test - dart::TimelineEventArguments::Free()
- [tool_crash] RPCError
- "pub is deprecated" error message when building flutter tool
- Move verification script in flutter_tools/test/general.shard/android/gradle_test.dart to integration.shard
- flake in long running web tests
- Existence of mockito in dev_dependencies will prevent error-free update-packages
- [null-safety] remove all usage of --enable-experiment from CI
- Some issues not shown.