New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Microsoft.EntityFrameworkCore.Analyzers into language-specific analyzers #22195
base: release/5.0
Are you sure you want to change the base?
Conversation
| <RootNamespace>Microsoft.EntityFrameworkCore</RootNamespace> | ||
|
|
||
| <IncludeBuildOutput>false</IncludeBuildOutput> | ||
| <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Oh wow, thanks for submitting this! We'll have a chat in EF triage a bit later today about it. |
nit: some markdown parsers require blank lines around tables.
Also, MD022 requires blank lines around headings.
| return syntax switch | ||
| { | ||
| _ => syntax, | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not return syntax directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems likely that someone would want to alter this in the future to provide more specific results for VB.
|
Postponing merging this PR as per #22177 (comment) |
|
This can be rebased and merged to main now. |
|
Note: am going to defer working on this until we make a decision on what happens with pubternality... Even though we may still want to provide analyzers for other purposes, this is the only one we currently have. |
|
Is there plans to continue this soon? |
Fixes #22177