Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Microsoft.EntityFrameworkCore.Analyzers into language-specific analyzers #22195

Draft
wants to merge 1 commit into
base: release/5.0
Choose a base branch
from

Conversation

Copy link
Member

@sharwell sharwell commented Aug 24, 2020

Fixes #22177

<RootNamespace>Microsoft.EntityFrameworkCore</RootNamespace>

<IncludeBuildOutput>false</IncludeBuildOutput>
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
Copy link
Member Author

@sharwell sharwell Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This line eliminates the need for the _._ files.

@roji
Copy link

@roji roji commented Aug 24, 2020

Oh wow, thanks for submitting this! We'll have a chat in EF triage a bit later today about it.

Copy link
Member

@Youssef1313 Youssef1313 left a comment

nit: some markdown parsers require blank lines around tables.
Also, MD022 requires blank lines around headings.

return syntax switch
{
_ => syntax,
};
Copy link
Member

@Youssef1313 Youssef1313 Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not return syntax directly?

Copy link
Member Author

@sharwell sharwell Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems likely that someone would want to alter this in the future to provide more specific results for VB.

@roji
Copy link

@roji roji commented Aug 24, 2020

Postponing merging this PR as per #22177 (comment)

@sharwell sharwell marked this pull request as draft Aug 24, 2020
@roji roji mentioned this pull request Aug 25, 2020
@smitpatel
Copy link

@smitpatel smitpatel commented Oct 16, 2020

This can be rebased and merged to main now.

@roji
Copy link

@roji roji commented Oct 22, 2020

Note: am going to defer working on this until we make a decision on what happens with pubternality... Even though we may still want to provide analyzers for other purposes, this is the only one we currently have.

@AraHaan
Copy link

@AraHaan AraHaan commented Mar 22, 2022

Is there plans to continue this soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants