Skip to content

/ Javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create NumberExponentiation.js #381

Open
wants to merge 1 commit into
base: master
from
Open

Create NumberExponentiation.js #381

wants to merge 1 commit into from

Conversation

@illegalcall
Copy link
Contributor

@illegalcall illegalcall commented Oct 2, 2020 •
edited

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@illegalcall
Create NumberExponentiation.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
78dc234
@itsvinayak
itsvinayak reviewed Oct 5, 2020
View changes
Recursive/NumberExponentiation.js
@@ -0,0 +1,19 @@
// Implement a fuction which calculates a number raised to the power n.

var myPow = function (x, n) {

This comment has been minimized.

Sign in to view
@itsvinayak

itsvinayak Oct 5, 2020
Member

  • use arrow function.
  • use the proper function name .
  • provide doc
@itsvinayak
itsvinayak requested changes Oct 5, 2020
View changes
Recursive/NumberExponentiation.js
return n < 0 ? 1 / result : result
}

function main () {

This comment has been minimized.

Sign in to view
@itsvinayak

itsvinayak Oct 5, 2020
Member

write this function as
(()=>{ // code })()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsvinayak itsvinayak

Assignees
No one assigned
Labels
Beginner Changes Required good first issue
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@illegalcall @itsvinayak
You can’t perform that action at this time.