Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows CI/CD #111

Open
wants to merge 1,248 commits into
base: master
from
Open

Windows CI/CD #111

wants to merge 1,248 commits into from

Conversation

@bonelli
Copy link
Contributor

@bonelli bonelli commented May 28, 2020

Here is a PR with Travis configured for Windows testing and 1 non-regression test of a particular case where Windows and MacOS crash

I'm not really interested in maintaining this non-regression test on the log run, it is there to investigate the issue.

h-g-s and others added 30 commits Jan 23, 2020
…rmatting mip_test also with black

Former-commit-id: 87abd0d
…rmatting mip_test also with black
Former-commit-id: 69afade
Former-commit-id: 6beb8ff
Former-commit-id: 08c7d46
Former-commit-id: d543d5f
Former-commit-id: 7d48127
Former-commit-id: 521c150
Former-commit-id: 2f29b00
Former-commit-id: aad95bf
Former-commit-id: 4d0eab6
@@ -4,6 +4,7 @@
from typing import List, Tuple, Optional, Union, Dict, Any
import numbers
import mip
import numpy as np

This comment has been minimized.

@jurasofish

jurasofish May 28, 2020
Contributor

already imported in the try except below, to make numpy optional

This comment has been minimized.

@h-g-s

h-g-s May 29, 2020
Contributor

Yes, you can remove the numpy import in the beginning

@jurasofish
Copy link
Contributor

@jurasofish jurasofish commented May 28, 2020

Good stuff, would it be worth getting rid of the appveyor testing if windows can be used with travis?

@h-g-s
Copy link
Contributor

@h-g-s h-g-s commented May 29, 2020

Good stuff, would it be worth getting rid of the appveyor testing if windows can be used with travis?

Yes ! Appveyor takes longer to start tests. Only Travis would be easier to maintain.
It seems that github now offers CI, but no idea on how to use it.

@jurasofish
Copy link
Contributor

@jurasofish jurasofish commented May 29, 2020

Yes ! Appveyor takes longer to start tests. Only Travis would be easier to maintain.
It seems that github now offers CI, but no idea on how to use it.

I was thinking of suggesting moving to it. Using github CI has the benefit that forks will automatically run tests - no need to configure travis. Has windows, linux, and mac, and it's unlimited for public repos.

I've worked with it a bit, I can have a go at setting it up if you'd like? Should be a pretty easy switch given all the scripts and configs are already established for travis and appveyor.

@h-g-s
Copy link
Contributor

@h-g-s h-g-s commented May 29, 2020

@jurasofish jurasofish mentioned this pull request May 31, 2020
@jurasofish
Copy link
Contributor

@jurasofish jurasofish commented Jun 23, 2020

This has gone a little stale - is there any chance of at the very least merging the regression test? Always good to have more diverse tests.

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Jun 24, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

bonelli
jurasofish
h-g-s
tuliotoffolo
You have signed the CLA already but the status is still pending? Let us recheck it.

@bonelli
Copy link
Contributor Author

@bonelli bonelli commented Jun 24, 2020

This has gone a little stale - is there any chance of at the very least merging the regression test? Always good to have more diverse tests.

I lost track of the advancements but I'd really appreciate python-mip to work in my case on Windows. What shall I do to quicken that?

@h-g-s h-g-s force-pushed the coin-or:master branch from 679f927 to dee2923 Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.