Skip to content

/ lab

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS support #76

Open
wants to merge 1 commit into
base: master
from
Open

macOS support #76

wants to merge 1 commit into from

Conversation

@didzis
Copy link

didzis commented Nov 3, 2017

Adds macOS support remaining compatible with other platforms, i.e., intended to be merged with master branch. Works for all three modes: non-headless, headless with hardware acceleration and headless with software rendering. Build instructions found in docs/build_macos.md. This addresses #7, #39 and possibly #22.
@googlebot
Copy link

googlebot commented Nov 3, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.
@didzis didzis force-pushed the didzis:macos branch from 321d6f6 to 3b5bfd9 Nov 3, 2017
@googlebot
Copy link

googlebot commented Nov 3, 2017

CLAs look good, thanks!
@didzis
macOS support
Loading status checks…
c634c0c
@didzis didzis force-pushed the didzis:macos branch from 3b5bfd9 to c634c0c Nov 3, 2017
@tkoeppe tkoeppe force-pushed the deepmind:master branch 2 times, most recently from 31fe629 to 87f8993 Dec 5, 2017
@tkoeppe tkoeppe force-pushed the deepmind:master branch from 79afaba to d817a04 May 1, 2018
@tkoeppe tkoeppe force-pushed the deepmind:master branch from e899e13 to e1bb912 May 22, 2018
@tkoeppe
tkoeppe reviewed Oct 12, 2018
View changes
public/dmlab_so_loader.cc
@@ -42,6 +44,44 @@
#error Must define DMLAB_SO_LOCATION dynamic library path.
#endif

#ifdef __APPLE__
ssize_t sendfile(int out_fd, int in_fd, off_t *offset, size_t count)

This comment has been minimized.

Sign in to view
@tkoeppe

tkoeppe Oct 12, 2018 Collaborator

sendfile is available on BSD/MacOSX as well, e.g. https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/sendfile.2.html. It might have a slightly different signature than on Linux, but we shouldn't need to reimplement it.
@tkoeppe tkoeppe force-pushed the deepmind:master branch from e608bdd to bed70eb Oct 16, 2018
tkoeppe added a commit that referenced this pull request Oct 18, 2018
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
09177b5
tkoeppe added a commit that referenced this pull request Oct 18, 2018
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
9171163
@tkoeppe
Copy link
Collaborator

tkoeppe commented Oct 18, 2018 •
edited

Hi! Are you still interested in this? I've put together a few smaller changes in the macos branch of this repository. At the top of that branch there's a commit that adds your new headless renderer, but that doesn't quite seem to work yet. If you like, feel free to send patches against that branch (e.g. by rebasing this pull request branch). I think all we need to do is fix up headless_macos_glimp.c.
@tkoeppe tkoeppe mentioned this pull request Oct 18, 2018
Open
tkoeppe added a commit that referenced this pull request Oct 19, 2018
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
cba45b4
tkoeppe added a commit that referenced this pull request Oct 20, 2018
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
86bbf54
tkoeppe added a commit that referenced this pull request Oct 23, 2018
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
d56aa7c
tkoeppe added a commit that referenced this pull request Oct 24, 2018
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
2f55247
tkoeppe added a commit that referenced this pull request Oct 30, 2018
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
641498e
tkoeppe added a commit that referenced this pull request Jan 14, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
fdcbce5
tkoeppe added a commit that referenced this pull request Jul 21, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
a51eae5
tkoeppe added a commit that referenced this pull request Jul 22, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
9210760
tkoeppe added a commit that referenced this pull request Jul 22, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
15be743
tkoeppe added a commit that referenced this pull request Jul 23, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
e0f188b
tkoeppe added a commit that referenced this pull request Jul 28, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
250930e
tkoeppe added a commit that referenced this pull request Jul 28, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
2a6150d
tkoeppe added a commit that referenced this pull request Jul 31, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
6f19fc9
tkoeppe added a commit that referenced this pull request Sep 17, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
0599dbf
tkoeppe added a commit that referenced this pull request Oct 8, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
a4b1897
tkoeppe added a commit that referenced this pull request Oct 21, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
bb70309
tkoeppe added a commit that referenced this pull request Oct 30, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
4a1851c
tkoeppe added a commit that referenced this pull request Dec 2, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
d331d4b
tkoeppe added a commit that referenced this pull request Dec 5, 2019
@tkoeppe
Headless renderer. Attempting something like in #76.
Loading status checks…
e2d1e39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@didzis @googlebot @tkoeppe
You can’t perform that action at this time.