MarshallOfSound
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign upPinned
2,585 contributions in the last year
Activity overview
Contribution activity
December 2020
Created 50 commits in 9 repositories
Created 4 repositories
- MarshallOfSound/CrewLink-server TypeScript
- MarshallOfSound/CrewLink TypeScript
- MarshallOfSound/css-in-readme-like-wat
- MarshallOfSound/uuaw JavaScript
Created a pull request in electron/electron that received 4 comments
fix: handle security warnings promise when JS is disabled
Fixes #26829
Notes: Fixes uncaught promise rejection when creating webContents with javascript disabled
+1
−1
•
4
comments
Opened 37 other pull requests in 7 repositories
electron/cation
14
merged
- fix: do not allow duplicate approvals
- fix: make the bullet points work correctly
- feat: add sentry error monitoring
- fix: bad require call in `24-hour-rule`
- feat: allow semver/none in the semver label enforcement check
- feat: include LGTM count in check title
- feat: update API Review check when new-pr is removed
- feat: update labels when new-pr is gone
- feat: add template for applying labels correctly
- feat: make the buttons update the check run body
- feat: buttons
- feat: make API Review check status match current label
- feat: add semver/* label enforcement on all new PRs
- feat: change 24 rule to 7 day rule for semver/minor and semver/major
MarshallOfSound/electron
9
open
electron/electron
3
open
3
merged
1
closed
- feat: enable context isolation by default
- feat: enable world safe JS by default
- build: fix JS linting
- chore: remove `app.allowRendererProcessReuse` and BrowserWindow `affinity` options
- Rename atom to electron
- feat: add support for DOM elements going over the context bridge
- build: use all-for-one goma
ottomated/CrewLink
1
closed
2
open
1
merged
electron/build-tools
1
merged
electron/roller
1
merged
electron/trop
1
merged
Reviewed 75 pull requests in 6 repositories
electron/electron 49 pull requests
- chore: remove extra setTitlebarAppearsTransparent
- fix: memory leak in desktopCapturer.getSources
- fix: stack traces in non-Node.js contexts
- fix: throw when using globalShortcut before ready
- ci: ignore failures on Ninja summary
- chore: bump chromium to 096e5313aaf19dfa0c4710145c34d (master)
- fix: screen EventEmitter methods with remote
- fix: screen EventEmitter methods with remote
- fix: install Node.js signal handlers in ELECTRON_RUN_AS_NODE
- fix: handle BrowserView reparenting
- fix: add SafeForTerminationScopes for SIGINT interruptions
- fix: Upload all *.dll.pdb to symbol server
- fix: Upload all *.dll.pdb to symbol server
- fix: Upload all *.dll.pdb to symbol server
- fix: Upload all *.dll.pdb to symbol server
- fix: Avoid crashing in NativeViewHost::SetParentAccessible on Windows 10
- fix: Avoid crashing in NativeViewHost::SetParentAccessible on Windows 10
- fix: Avoid crashing in NativeViewHost::SetParentAccessible on Windows 10
- refactor: create Object.defineProperty() wrapper
- fix: Update Squirrel.mac to fix permissions bug.
- fix: Upload all *.dll.pdb to symbol server
- feat: add missing webFrameMain.executeJavaScriptInIsolatedWorld()
- fix: restrict sendToFrame to same-process frames by default
- fix: restrict sendToFrame to same-process frames by default (#26875)
- fix: restrict sendToFrame to same-process frames by default (#26875)
- Some pull request reviews not shown.
electron/cation 14 pull requests
- fix: feat backports do not need to have new-pr
- feat: include time remaining in check
- chore: update deprecated WebhookError props
- fix: don't remove nonexistent labels
- test: add semver enforcement specs
- fix: update new-pr label if semver changes
- build: add lint workflow
- fix: prevent pr author from LGTMing own PR
- fix: clean up EventPayloads types
- feat: only allow the API WG chair to decline an API
- feat: validate API decision sender
- feat: remove api-review/* labels added by humans
- feat: handle api-review unlabeling
- feat: auto-label semver/{minor, major} PRs
MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL- 7 pull requests
electron/trop 3 pull requests
electron/debian-sysroot-image-creator 1 pull request
electron/electron-rebuild 1 pull request
Created an issue in electron/cation that received 1 comment
Opened 5 other issues in 1 repository
electron/cation
4
closed
1
open
Answered 1 discussion in 1 repository
sindresorhus/awesome-electron
sindresorhus/awesome-electron
16
contributions
in private repositories
Dec 1 – Dec 15