Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display process warning stack traces by default #33349

Open
szmarczak opened this issue May 11, 2020 · 8 comments
Open

Display process warning stack traces by default #33349

szmarczak opened this issue May 11, 2020 · 8 comments

Comments

@szmarczak
Copy link
Contributor

@szmarczak szmarczak commented May 11, 2020

Is your feature request related to a problem? Please describe.

Recently I've come to an issue, where the author provided only TimeoutOverflowWarning without any stack traces whatsoever, therefore I'm unable to locate the source.

Describe the solution you'd like

I'd propose to enable process warning stack traces by default, so people don't have to node --trace-warnings index.js. There would be another option to disable that, --no-trace-warnings.

@mmarchini
Copy link
Member

@mmarchini mmarchini commented May 20, 2020

Sounds good to me. This looks like a good first issue, unless I'm wrong? (I added the label, if anyone things that's not a good first issue feel free to remove it).

@bhumijgupta
Copy link

@bhumijgupta bhumijgupta commented May 20, 2020

I would like to take up this issue. Can someone guide me through it as I am a first time contributor and the codebase is huge.
CC @mmarchini

@bhumijgupta
Copy link

@bhumijgupta bhumijgupta commented May 25, 2020

Gentle ping @mmarchini

@mmarchini
Copy link
Member

@mmarchini mmarchini commented May 27, 2020

Hey @bhumijgupta, sorry for the delay, I didn't check GitHub during the long weekend. Have you contributed to the project before? If you haven't, I suggest starting by cloning the repository and making sure you can build it. Instructions to build are available in https://www.github.com/nodejs/node/tree/master/BUILDING.md.

@preyunk
Copy link
Contributor

@preyunk preyunk commented May 27, 2020

@mmarchini I've cloned the repository and built the source code. Willing to take up the issue if @bhumijgupta is not working on it.

@bhumijgupta
Copy link

@bhumijgupta bhumijgupta commented May 27, 2020

@preyunk I am working on the issue, although it may take some time for me to land a PR since the codebase and the tests affected by the changes are more in number

@jasnell
Copy link
Member

@jasnell jasnell commented May 27, 2020

I'm generally -1 on displaying the stack traces by default. Warnings can already be very noisy, particularly deprecation warnings. Making them more noisy likely isn't going to be received well by most users.

@szmarczak
Copy link
Contributor Author

@szmarczak szmarczak commented May 27, 2020

Warnings can already be very noisy, particularly deprecation warnings.

Then maybe let's deprecate it and hard reject?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.