Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesOpen notes in new window #3110
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sbencoding commentedJul 7, 2019
•
edited by issuehunt-app bot
Description
This PR adds the ability to open and edit notes in separate, new windows.
The new windows only implement the
Detailcomponent, so there's only one main window.The
full screenbutton has been removed from the new windows, because I don't think it has purpose in that context. The editor already covers the entire window.I also had to add a new string to
i18n: Open in new window. English and Hungarian versions are correct, but for the rest of the languages I simply added the english text.Some images of the new feature:
Issue fixed
#1572 [Feature Request] Multiple notes open in their own dedicated windows.
Type of changes
Checklist:
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor