Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interpolation search and updated README.md #248

Open
wants to merge 5 commits into
base: master
from

Conversation

@Kingarturs
Copy link

@Kingarturs Kingarturs commented Oct 25, 2020

Hi there! I added interpolation search algorithm and it's description in the README.md

Hope it helps 🚀

@Kingarturs Kingarturs requested a review from Mystigan as a code owner Oct 25, 2020
Copy link
Collaborator

@nomisrevol nomisrevol left a comment

Change file name to interpolationsearch.go and add test to search_test. You can add more tests, it's very helpful and you're welcome.

@@ -0,0 +1,47 @@
package main

This comment has been minimized.

@nomisrevol

nomisrevol Oct 27, 2020
Collaborator

It should belong to package searches.

This comment has been minimized.

@Kingarturs

Kingarturs Oct 27, 2020
Author

I noticed that every file on the searches folder is in the main package, should i leave mine there too or make it a separate package?

This comment has been minimized.

@Kingarturs

Kingarturs Oct 27, 2020
Author

It could imply to make a separate folder of the same name inside searches (as far as i know).
I can:

  1. Change package of the go files inside the folder to searches
  2. Leave my function in the main package the avoid import problems

This comment has been minimized.

@nomisrevol

nomisrevol Oct 30, 2020
Collaborator

It's better to change it to package searches and the other search implementation should be changed to package searches too.

return -1
}

func main() {

This comment has been minimized.

@nomisrevol

nomisrevol Oct 27, 2020
Collaborator

Remove main function, create test file instead.

cclauss and others added 4 commits Oct 27, 2020
@Kingarturs Kingarturs requested a review from nomisrevol Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.