Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Poor error if chmod fails #195
Open
Comments
|
odd, why is it trying to chmod it...? |
|
It tries to chmod it to prevent overly readable secrets. In a past version, the default was world-readable secrets. The error behavior should definitely be different. PRs welcome. |
|
Ah yes when I wrote the original jar I didn't set a umask on file creation -- thanks for clarifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried providing my github cookie as a Docker secret. Docker makes it appear inside the container as a world-readable file at
/run/secrets/cookie.It appears that ocaml-github checks the permissions, tries to chmod it (!), fails, throws away the error, and reports that the token doesn't exist. Quite confusing...
I guess this is the problem line:
ocaml-github/unix/github_cookie_jar.ml
Line 164 in ef5c33b