[Issue 8894][Offloader] Fix AWS credentials usages #8950
Merged
Conversation
|
Overall the change looks good to me. But can we add some integration tests for it? |
KannarFr
force-pushed the
CleverCloud:fixcreds
branch
2 times, most recently
from
8f1fd7e
to
2212cfa
|
@sijie it that ok? |
|
@KannarFr Can you fix the failed tests? |
KannarFr
force-pushed the
CleverCloud:fixcreds
branch
2 times, most recently
from
065fbdd
to
567b1ce
|
@sijie can you rerun canceled? |
|
/pulsarbot run-failure-checks |
|
@sijie can you merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #8894
Motivation
In #7950 I introduce usage of AWS credentials Id/Secret, but defined STS role & roleSessionName, this PR comes to fix the correct variables names and support both of credentials types.
Does this pull request potentially affect one of the following parts:
Documentation