Skip to content

/ alertmanager

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dispatch: convert to a function. #2056

Open
wants to merge 1 commit into
base: master
from
Open

dispatch: convert to a function. #2056

wants to merge 1 commit into from

Conversation

@johncming
Copy link
Contributor

@johncming johncming commented Sep 27, 2019 •
edited

cleanup is an important function that involves the close of alerts, convert to a function is better.
@johncming
dispatch: convert to a function.
Loading status checks…
0b2b841 
Signed-off-by: johncming <johncming@yahoo.com>
@simonpasquier
Copy link
Member

@simonpasquier simonpasquier commented Oct 2, 2019

I don't find personally that the change makes the code clearer. But happy to hear a different opinion from @mxinden and @stuartnelson3.
@stuartnelson3
Copy link
Contributor

@stuartnelson3 stuartnelson3 commented Oct 2, 2019

yeah, I don't really see any change here 🤷‍♂
@mxinden
mxinden reviewed Oct 4, 2019
View changes
Copy link
Contributor

@mxinden mxinden left a comment

I would also prefer the current implementation.
@stale stale bot added the stale label Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@johncming @simonpasquier @stuartnelson3 @mxinden
You can’t perform that action at this time.