Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay check should be closed interval operation #2135

Open
wants to merge 1 commit into
base: master
from

Conversation

@johncming
Copy link
Contributor

@johncming johncming commented Dec 11, 2019

The overlapping checks on the boundary are ignored which should be closed interval operation.

if (alert.EndsAt.After(old.StartsAt) && alert.EndsAt.Before(old.EndsAt)) ||
(alert.StartsAt.After(old.StartsAt) && alert.StartsAt.Before(old.EndsAt)) {
alert = old.Merge(alert)
}

Signed-off-by: johncming <johncming@yahoo.com>
@stale stale bot added the stale label Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.