johncowen
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Popular repositories
846 contributions in the last year
Activity overview
Contributed to
hashicorp/consul,
hashicorp/consul-api-double,
johncowen/iris
and 5 other
repositories
Contribution activity
November 2020
Created 21 commits in 1 repository
Created a pull request in hashicorp/consul that received 4 comments
ui: Replace NaN and undefined metrics values with `-`
This PR does four things: Updates our mock API to be slightly more random during smoke testing, which means we can work with/see more eventualities .
+169
−162
•
4
comments
Opened 20 other pull requests in 1 repository
hashicorp/consul
19
merged
1
closed
- ui: Search/sort improvements
- ui: Upstream Instance Search and Sort
- ui: Add vendor directory as a target for JS linting and lint
- ui: Move DiscoveryChain component
- ui: Inline Topology Intention Actions
- ui: Correct AdapterError import
- ui: Remove unnecessary reopens from sort and form services
- ui: Move ember-data classes to use native JS classes/decorators
- ui: Move notice storybook to use controls addon
- ui: Ensure per service intentions link to the correct place
- ui: Default to glimmer components
- ui: Move gitignore file to workspace root and add storybook ignores
- ui: Intention "Action change" warning modal
- ui: Move AppError and ErrorState to glimmer components
- ui: Metrics - Provide a fetch-like http client that automatically adds the current ACL token
- ui: Run Ember native class code mod
- ui: Move mocks into the ui project
- ui: Add external API mock packages as sibling packages
- ui: Use eslint vs ember-cli-lint, sass vs dart-sass
- ui: Remove string casting when passing index/checked for dropmenus
Reviewed 10 pull requests in 2 repositories
hashicorp/consul 8 pull requests
- ui: Pass down nspace and dc from Service model down to prometheus request
- ui: Update to not return metrics for ingress gateways (#9081)
- ci(backport-1.8): publish static assets
- ui: Topology Intentions Popovers
- ui: Delete proxy info tab
- ui: Move ember-data classes to use native JS classes/decorators
- ui: remove consul-api-double from yarn.lock
- ui: Update to not return metrics for ingress gateways