vercel / next.js

The React Framework

nextjs.org

58.7k stars 10.1k forks

Watch

mattfwood Extend IncomingMessage type to include cookies from middleware (#19724 )

Extend IncomingMessage type to include cookies from middleware (#19724 )

When using `getServerSideProps` with Typescript, it looks like it's expecting `req` to be a plain `IncomingMessage` from `http`, but Next middleware (?) is adding `cookies`:

![image](https://user-images.githubusercontent.com/22530815/100816292-680e8a00-340b-11eb-8c40-19ec4f9ea356.png)

Here's a reproduction showing the example:

https://codesandbox.io/s/nextjs-server-side-props-cookies-vr547?file=/pages/index.tsx

In the terminal, you can see that there is a value for cookies, but `IncomingMessage` doesn't include it by default.

I still need to get more familiar with all the Next.js internals, but I imagine there are a few other places where this type could be used if cookies are being included. Any help would be appreciated.

7d48241

7,483 commits

Failed to load latest commit information.

readme.md

Next.js

Getting Started

Visit https://nextjs.org/learn to get started with Next.js.

Documentation

Visit https://nextjs.org/docs to view the full documentation.

Who is using Next.js?

Next.js is used by the world's leading companies. Check out the Next.js Showcase to learn more.

Community

The Next.js community can be found on GitHub Discussions, where you can ask questions, voice ideas, and share your projects.

To chat with other community members you can join the Next.js Discord.

Our Code of Conduct applies to all Next.js community channels.

Contributing

Please see our contributing.md.

Authors

Arunoda Susiripala (@arunoda) – Vercel
Tim Neutkens (@timneutkens) – Vercel
Naoyuki Kanezawa (@nkzawa) – Vercel
Tony Kovanen (@tonykovanen) – Vercel
Guillermo Rauch (@rauchg) – Vercel
Dan Zajdband (@impronunciable) – Knight-Mozilla / Coral Project

About

The React Framework

nextjs.org

react server-rendering universal node components browser nextjs zeit vercel static-site-generator hybrid ssg static-site-generation static blog compiler tooling toolbox

Releases 1,013

+ 1,012 releases

Packages

No packages published

Used by 170k

Contributors 1,403

+ 1,392 contributors

Languages

You can’t perform that action at this time.