Have to_type behave the same for torch.Tensor and custom types #711
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Currently,
to_type()behaves differently fortorch.Tensorand custom types, callingto()directly on the custom type object without checking wether its data is floating point and residing on a GPU.This change allows for custom types to be treated the same as standard tensors, properly handling non-floating point values, provided they also expose
is_floating_point,is_cudaandto.