Fwd/bwd compatibility around pip 19.3 #594
Open
Conversation
|
LGTM. |
| @@ -32,6 +31,10 @@ | |||
| ext_modules = [] | |||
|
|
|||
| if "--pyprof" in sys.argv: | |||
| try: | |||
| from pip._internal import main as pipmain | |||
ptrblck
Dec 13, 2019
Collaborator
19.3.1 will be able to import it without an ImportError, so we need to call pipmain and catch the TypeError instead.
19.3.1 will be able to import it without an ImportError, so we need to call pipmain and catch the TypeError instead.
ptrblck
Dec 13, 2019
Collaborator
This should work:
if "--pyprof" in sys.argv:
try:
from pip._internal import main as pipmain
pipmain() # dummy call to raise the TypeError for pip >= 19.
except TypeError:
from pip._internal.main import main as pipmain
This should work:
if "--pyprof" in sys.argv:
try:
from pip._internal import main as pipmain
pipmain() # dummy call to raise the TypeError for pip >= 19.
except TypeError:
from pip._internal.main import main as pipmain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #548 (comment).
@mkolod @adityaiitb as original authors of Pyprof, what do you guys think?