Skip to content

/ plugins Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[camera_platform_interface] Add torch definition to the FlashModes enum #3326

Merged
merged 2 commits into from Dec 16, 2020
Merged

[camera_platform_interface] Add torch definition to the FlashModes enum #3326

merged 2 commits into from Dec 16, 2020

Conversation

@mvanbeusekom
Copy link
Task lists! Give feedback
Contributor

@mvanbeusekom mvanbeusekom commented Dec 14, 2020 •
edited

Description

This PR adds the additional torch value to the FlashModes enum, which when implemented should turn on the flash light and keep it on until it is manually turned-off.

Related Issues

flutter/flutter#19845
flutter/flutter#37853

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.
@mvanbeusekom
Fix formatting issues
4daaffa
@mvanbeusekom
Make sure torch value is serialized correctly
e3cfddf
@google-cla google-cla bot added the cla: yes label Dec 14, 2020
bparrishMines
bparrishMines approved these changes Dec 16, 2020
View changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

LGTM

@mvanbeusekom mvanbeusekom merged commit b85d8eb into flutter:master Dec 16, 2020
32 checks passed
32 checks passed
@wip[bot]
WIP Ready for review
Details
@flutter-dashboard[bot]
Windows Plugins
Details
@cirrus-ci[bot]
analyze Task Summary
Details
@cirrus-ci[bot]
build-apks+java-test+firebase-test-lab CHANNEL:master PLUGIN_SHARDING:--shardIndex 0 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-apks+java-test+firebase-test-lab CHANNEL:master PLUGIN_SHARDING:--shardIndex 1 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-apks+java-test+firebase-test-lab CHANNEL:master PLUGIN_SHARDING:--shardIndex 2 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-apks+java-test+firebase-test-lab CHANNEL:master PLUGIN_SHARDING:--shardIndex 3 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-apks+java-test+firebase-test-lab CHANNEL:stable PLUGIN_SHARDING:--shardIndex 0 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-apks+java-test+firebase-test-lab CHANNEL:stable PLUGIN_SHARDING:--shardIndex 1 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-apks+java-test+firebase-test-lab CHANNEL:stable PLUGIN_SHARDING:--shardIndex 2 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-apks+java-test+firebase-test-lab CHANNEL:stable PLUGIN_SHARDING:--shardIndex 3 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-apps+drive-examples Task Summary
Details
@cirrus-ci[bot]
build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 0 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 1 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 2 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 3 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 0 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 1 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 2 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 3 --shardCount 4 Task Summary
Details
@cirrus-ci[bot]
build-linux+drive-examples Task Summary
Details
@cirrus-ci[bot]
build_all_plugins_apk Task Summary
Details
@cirrus-ci[bot]
build_all_plugins_app Task Summary
Details
@cirrus-ci[bot]
build_all_plugins_ipa Task Summary
Details
@google-cla[bot]
cla/google All necessary CLAs are signed
@cirrus-ci[bot]
format Task Summary
Details
@cirrus-ci[bot]
lint_darwin_plugins PLUGIN_SHARDING:--shardIndex 0 --shardCount 2 Task Summary
Details
@cirrus-ci[bot]
lint_darwin_plugins PLUGIN_SHARDING:--shardIndex 1 --shardCount 2 Task Summary
Details
@cirrus-ci[bot]
publishable Task Summary
Details
@submit-queue[bot]
submit-queue Ready to merge!
Details
@cirrus-ci[bot]
test CHANNEL:master Task Summary
Details
@cirrus-ci[bot]
test CHANNEL:stable Task Summary
Details
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 16, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
6a51438 
…Modes enum (flutter/plugins#3326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 16, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
92ac5f1 
…Modes enum (flutter/plugins#3326)
@BeMacized BeMacized mentioned this pull request Dec 16, 2020
Merged
13 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 16, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
0a63239 
…Modes enum (flutter/plugins#3326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 16, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
9788a28 
…Modes enum (flutter/plugins#3326)
NickalasB added a commit to NickalasB/plugins that referenced this issue Dec 17, 2020
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
84fe69a 
* master:
  [camera] Ios support documentation  (flutter#3335)
  Remove custom null safety analysis_options files (flutter#3339)
  [webview_flutter] Added 'allowsInlineMediaPlayback' property (flutter#3334)
  [camera_platform_interface] Add torch definition to the FlashModes enum  (flutter#3326)
  [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flutter#3271)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java
#	packages/webview_flutter/lib/platform_interface.dart
#	packages/webview_flutter/pubspec.yaml
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 17, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
eff8b2a 
…Modes enum (flutter/plugins#3326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 18, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
c7ef0de 
…Modes enum (flutter/plugins#3326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 18, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
986415f 
…Modes enum (flutter/plugins#3326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 18, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
2c9a2fa 
…Modes enum (flutter/plugins#3326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 18, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
53b4733 
…Modes enum (flutter/plugins#3326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 18, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
0eb3220 
…Modes enum (flutter/plugins#3326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 19, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
b8b1957 
…Modes enum (flutter/plugins#3326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 19, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
8217a87 
…Modes enum (flutter/plugins#3326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 19, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
33c6109 
…Modes enum (flutter/plugins#3326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 20, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 20, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
98b2756 
…Modes enum (flutter/plugins#3326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 29, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Dec 29, 2020
@engine-flutter-autoroll
b85d8eb [camera_platform_interface] Add torch definition to the Flash…
82ff68d 
…Modes enum (flutter/plugins#3326)
amantoux added a commit to amantoux/plugins that referenced this issue Feb 8, 2021
@mvanbeusekom @amantoux
[camera_platform_interface] Add torch definition to the FlashModes en…
b958444 
…um (flutter#3326)

* Fix formatting issues

* Make sure torch value is serialized correctly
adsonpleal added a commit to nubank/plugins that referenced this issue Feb 26, 2021
@mvanbeusekom @adsonpleal
[camera_platform_interface] Add torch definition to the FlashModes en…
ac20d64 
…um (flutter#3326)

* Fix formatting issues

* Make sure torch value is serialized correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparrishMines bparrishMines

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
2 participants
@mvanbeusekom @bparrishMines