Fix dropdown interaction #1088
Open
Fix dropdown interaction #1088
Conversation
added 2 commits
Mar 12, 2020
…ts, this covers the case of overlapping UI elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fix enables the PerformRaycast method to instead go through all TrackedDeviceRaycasters in order to get the correct element while respecting canvas sorting order.
The current method only returns the first hit from the first TrackedDeviceRaycaster preventing nested canvas components from returning the correct element being selected which causes dropdown menus to be unusable as they have their own canvas and TrackedDeviceRaycaster.
Checks to compare canvas sorting order, ensures that the closest element chosen is correct in the case of overlapping canvases. This would occur if a dropdown menu covers another UI element. GetComponentInParent on the raycast gameobject is required due to protection level of the canvas variable in TrackedDeviceRaycaster
This resolves issue #1087