Skip to content

/ openlibrary

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate orphaned edition code from addbook.py #4307

Merged
merged 1 commit into from Jan 23, 2021
Merged

Remove duplicate orphaned edition code from addbook.py #4307

merged 1 commit into from Jan 23, 2021
+2 −11

Conversation

@cclauss
Copy link
Collaborator

@cclauss cclauss commented Dec 18, 2020

Closes #4286 (comment)

Technical

Testing

Screenshot

Stakeholders
@cclauss
Remove duplicate orphaned edition code from addbook.py
Loading status checks…
43a042e
@cclauss cclauss added this to the Active Sprint milestone Dec 18, 2020
@cclauss cclauss requested review from hornc and mekarpeles Dec 18, 2020
@cclauss cclauss mentioned this pull request Dec 18, 2020
Merged
@mekarpeles mekarpeles self-assigned this Dec 27, 2020
@cdrini cdrini modified the milestones: Active Sprint, Next (proposed) Jan 4, 2021
@cclauss cclauss modified the milestones: Next (proposed), Active Sprint Jan 5, 2021
@cclauss
Copy link
Collaborator Author

@cclauss cclauss commented Jan 5, 2021

@hornc This was done at your request (#4286 (comment)) so can I please get your review?
@mekarpeles
Copy link
Member

@mekarpeles mekarpeles commented Jan 23, 2021 •
edited

This looks okay to me but @hornc is definitely more knowledgeable than I am on orphaned editions code.

Going to merge as a TIAS (try it and see) given both your + charles' insights
@mekarpeles mekarpeles merged commit 3b98277 into internetarchive:master Jan 23, 2021
3 checks passed
3 checks passed
javascript_tests
Details
python_tests (2.7)
Details
python_tests (3.8)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hornc hornc

@mekarpeles mekarpeles

Assignees

@mekarpeles mekarpeles

Labels
Type: Refactor/Clean-up
Projects
None yet
Milestone
Active Sprint
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@cclauss @mekarpeles @cdrini