Hi there 👋
I'm an engineer at Google Cloud. Previously I worked at HashiCorp, Chef Software, CustomInk, and some Pittsburgh-based startups.
💬 Ask me about: Go, Ruby😄 Pronouns: he/him🌍 Website
sethvargo
Follow
Pinned
3,083 contributions in the last year
Activity overview
Contributed to
google/exposure-notifications-verification-server,
google/exposure-notifications-server,
google-github-actions/setup-gcloud
and 5 other
repositories
Contribution activity
December 2020
Created 97 commits in 4 repositories
Created 1 repository
Created a pull request in google/exposure-notifications-verification-server that received 4 comments
Introduce RBAC
This introduces Role-Based Access Controls (RBAC) into the system. Common operations in the system are split into Read (view-only) and Write (creat…
+2,703
−1,878
•
4
comments
Opened 95 other pull requests in 2 repositories
google/exposure-notifications-verification-server
4
open
76
merged
2
closed
- Add tests for template middleware
- Add tests for sessions middleware
- Add tests for request_id middleware
- Add tests for MFA middleware
- Calculate grace periods from membership date
- Add tests for membership middleware
- Add tests for i18n middleware
- Add tests for header middleware
- Add tests for current_path middleware
- Recover from panics in main
- Add tests for csrf middleware
- Add tests for email_verified middleware
- Add tests for chaff middleware
- Add tests for debug middleware
- Add tests for method middleware
- Update logger package
- Match owners to repo membership
- Give admins the ability to disable AppStore redirects
- Add zapw to detect misuse of logger
- Check for unclosed response bodies
- Add tests for apikey middleware
- Add tests for firewall
- Bump core server to pull in logger changes
- Add more tests for realmadmin
- Add internal error check tests for mobileapps
- Some pull requests not shown.
google/exposure-notifications-server
12
merged
1
closed
- Revert back to old owners
- Testing changes
- Match owners to the team membership
- Improve control over logging package
- Add zapw and bodyclose
- Do not sample logs in production
- Update deps
- Add linters for Terraform
- Fix typo
- Bump export service to 2G RAM
- Increase p50 on cleanup-export to 60s
- Add unit tests for mirror service
- Enable pgaudit
Reviewed 114 pull requests in 3 repositories
google/exposure-notifications-verification-server 91 pull requests
- Display OS on the mobile apps index table
- Adding some realm test coverage
- Fix a link
- Add tests for chaff middleware
- Add in the current date to the bulk upload receipt csv filename
- Some nits from other PRs
- An odd test flake in integration_e2e
- Give admins the ability to disable AppStore redirects
- Staticify bulk issue js
- Fix potentially incorrect line numbers
- Show success UUIDs and provide file receipt for bulk-issue
- adding per service slo config
- Change some error levels for certificate api
- Prefer net split over custom indexof
- Add unit test for membership list/selectfirst
- Use first available membership for password reset
- Use realm from current membership for emails
- Refactoring issue codes
- Part 1: refactor issue-code
- Add full integration test coverage for API keys
- separate batch-issue from other e2e flows
- Test for single issue code
- Let CI print out git diff
- Terraform destroy first remove database from state
- Use envvar to increase stackdriver timeout to 1min.
- Some pull request reviews not shown.
google/exposure-notifications-server 22 pull requests
- Add zapw and bodyclose
- Restrict ingress traffic.
- Metrics
- Terraform: add hash from CI runner
- Terraform destroy first remove database from state
- Add terraform lock to source control
- Update google provider to 3.51
- Update notification channel setting in key server.
- Adjust Stackdriver export timeout to 1 minute.
- Upgrade terraform to 0.14.2 in presubmit test image
- Add a knob to enable Load Balancer logging.
- Exclude a rule in Cloud Armor.
- additional data defaults when importing keys from export files
- Terraform: VPC connector depends on service networking connection
- Remove the reference to the metrics middleware.
- deflake test
- don't stop retrying azure credential refresh on single failure
- allow for max records to be overridden on a per-export-config basis
- add tool to visualize links in an export file
- Unit test testing large batch exports
- Fix the MQL query, remove group by type.
- Adjust latency alert threshold
sethvargo/go-githubactions 1 pull request
Created an issue in google/exposure-notifications-verification-server that received 4 comments
Refactor VerificationCode.Validate to separate user error from system error
At present, VerificationCode.Validate returns an error for user error (e.g. invalid symptom onset date) and system error (e.g. code too short).
We …
4
comments
Opened 14 other issues in 3 repositories
google/exposure-notifications-verification-server
9
closed
3
open
- ErrTestTooOld is hard coded to 14 days
- RBAC Write permissions should include Read
- Provide API endpoints for accessing statistics
- Alert when a human accesses a secret
- Allow bulk management of user permissions
- Add descriptions for RBAC roles
- Test migration from pre-RBAC to post-RBAC
- Write a test that migration numbers are strictly increasing
- Check 401 permissions to sign out
- Pass through Twilio 4xx errors to the caller
- Captcha fails to load on failed login
- Per-day per-user stats visualization
uber-go/zap
1
open
google/exposure-notifications-server
1
closed
30
contributions
in private repositories
Dec 1 – Dec 24