Adding Makefile #278
Draft
Adding Makefile #278
+57
−19
Conversation
daviddavis
force-pushed the
daviddavis:issue6938
branch
3 times, most recently
from
e6e9b96
to
ba0b6e0
|
Attached issue: https://pulp.plan.io/issues/6938 Attached issue: https://pulp.plan.io/issues/6203 Attached issue: https://pulp.plan.io/issues/5107 |
daviddavis
force-pushed the
daviddavis:issue6938
branch
3 times, most recently
from
655999e
to
9be38c6
|
I like the idea. |
daviddavis
force-pushed the
daviddavis:issue6938
branch
5 times, most recently
from
4039f47
to
0cc2479
| $(VENV)/bin/pip install -qr dev_requirements.txt | ||
| $(VENV)/bin/pip install -qr test_requirements.txt | ||
| $(VENV)/bin/pip install -qe . | ||
| echo "Set up venv environment at $(VNV)" |
mdellweg
Nov 4, 2020
Member
Suggested change
echo "Set up venv environment at $(VNV)"
echo "Set up venv environment at $(VENV)"
Suggested change
| echo "Set up venv environment at $(VNV)" | |
| echo "Set up venv environment at $(VENV)" |
Adding a Makefile for plugin writers to define common tasks such as linting, running tests, etc. fixes #6938 fixes #6203 fixes #5107
|
@daviddavis Should this be closed out, or is it simple enough to get it finished soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Adding a Makefile for plugin writers to define common build related tasks such as linting, running tests, etc. Inspiration comes from other python projects such as dynaconf, celery, and rq.
One of the main goals is to allow developers to run the same checks locally as Travis does by using
make.These commands also create a virtual env that isolates the plugin's dev/test dependencies from other plugins as sharing these deps has led to problems. As one example, flake8 plugins automatically run if they are installed but they can differ from plugin to plugin (for example, some plugins are using flake8-docstrings while others don't).
I'm hoping this will also serve as a place where plugin writers will be able to define more build type tasks related to releasing, etc.
Feedback welcome.
TODO
fixes #6938
fixes #6203
fixes #5107