Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`TCPConnection.userAgent` isn't initialised correctly #1703

Open
PeterSurda opened this issue Jan 3, 2021 · 0 comments
Open

`TCPConnection.userAgent` isn't initialised correctly #1703

PeterSurda opened this issue Jan 3, 2021 · 0 comments
Labels
Projects
Milestone

Comments

@PeterSurda
Copy link
Member

@PeterSurda PeterSurda commented Jan 3, 2021

Randomly travis brought this up:

Traceback (most recent call last):
  File "/var/lib/buildbot/workers/default/travis_bionic/build/src/bitmessageqt/tests/main.py", line 34, in tearDown
    self.fail('Exception in the main thread: %s' % exc)
AssertionError: Exception in the main thread: TCPConnection instance has no attribute 'userAgent'

I looked and TCPConnection.userAgent isn't initialised in __init__, only later.

@PeterSurda PeterSurda added the bug label Jan 3, 2021
@PeterSurda PeterSurda added this to To do in Bugs via automation Jan 3, 2021
@PeterSurda PeterSurda added this to the v0.6.4 milestone Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bugs
  
To do
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.