fix: locale-independent gpg output parsing

[twz123]

Explicitly specify the "C" language during the invocation of the gpg binary. That way, parsing its output is more robust on non-english systems.

Signed-off-by: Tom Wieczorek t.wieczorek@yieldlab.de

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• My build is green (troubleshooting builds).

[codecov-io]

Codecov Report

Merging #5269 (12dc699) into master (ae6b824) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5269   +/-   ##
=======================================
  Coverage   40.89%   40.89%           
=======================================
  Files         136      136           
  Lines       18423    18423           
=======================================
  Hits         7534     7534           
  Misses       9813     9813           
  Partials     1076     1076           

Impacted Files	Coverage Δ
util/gpg/gpg.go	67.70% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6b824...12dc699. Read the comment docs.

[jannfis]

Good catch!

Can you please extend this to also change the call for the Git verify-commit operation in util/git/client.go - I think we don't set the locale when running Git, so the output of GnuPG when verifying signatures could be affected as well.

argo-cd/util/git/client.go

Line 499 in ae6b824

cmd.Env = append(cmd.Env, fmt.Sprintf("GNUPGHOME=%s", common.GetGnuPGHomePath()))

[jannfis]

LGTM. Thank you, @twz123!