Fix for #692: Re-initialize StreamContainer when nb_streams changes during demuxing #694
Conversation
brglng
changed the title
| @@ -111,6 +111,7 @@ cdef class InputContainer(Container): | |||
| # (and others). | |||
| id(kwargs) | |||
|
|
|||
|
|
|||
jlaine
Aug 27, 2020
Collaborator
Please remove this unrelated change
Please remove this unrelated change
| self.streams.add_stream(wrap_stream(self, self.ptr.streams[i])) | ||
|
|
||
| for i in range(self.ptr.nb_streams): | ||
| include_stream[i] = False |
jlaine
Aug 27, 2020
Collaborator
How do we know include_stream is the correct size, it only seems to be allocated once?
How do we know include_stream is the correct size, it only seems to be allocated once?
brglng
Aug 28, 2020
Author
I should re-allocate include_stream. Thanks.
I should re-allocate include_stream. Thanks.
|
I'm not comfortable with merging this change without any kind of unit tests. Can you please provide tests which increase / reduce the number of streams to make sure we exercise all possible conditions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fix for files whose
nb_streamschanges during demuxing/decoding.