jmagman
Follow
Pinned
1,793 contributions in the last year
Less
More
Contribution activity
February 2021
Created 20 commits in 2 repositories
Created a pull request in flutter/infra that received 6 comments
Remove tool_general_tests and tool_command_tests builders
Revert part of #339.
Evidently shard properties without subshards crash. https://flutter.googlesource.com/recipes/+/refs/heads/master/recipe_module…
+471
−2,913
•
6
comments
Opened 21 other pull requests in 2 repositories
flutter/flutter
3
open
14
merged
1
closed
- Add exception to FakeCommand
- MockProcessManager -> FakeProcessManager
- Move FakeBotDetector to fakes
- Revert tool change
- Install prebuilt iOS app only once
- Suggest precache instead of build when engine artifacts are missing
- Return an empty FlutterViews list when the service disappears
- Mark flutter_immediately_exit_test as unflaky
- Replace MockPlistParser with FakePlistParser
- Run flutter_driver, integration_test, flutter_localizations, and fuchsia_remote_debug_protocol in framework_tests presubmit
- Mark tool_integration_tests not flaky
- Remove hard-coded subshard numbers from the test runner
- Remove dead tool_coverage code
- Adopt subshard naming convention in build_tests
- Adopt tool_test shard builders
- Replace context FakeUsage with TestUsage
- Avoid iOS local networking dialog in integration tests
- Revert "Migrate driver tests in example/ to NNBD"
flutter/infra
1
open
2
merged
Reviewed 13 pull requests in 3 repositories
flutter/flutter 11 pull requests
- Move FakeBotDetector to fakes
- [flutter_tools] update error message of ProcessManager resolution failure
- Added memory benchmark for flutter engine groups.
- [flutter_tools] use a single fake implementation of HttpClient
- add prod builder for android stack size test
- Install prebuilt iOS app only once
- Revert "add a benchmark test for stack size"
- Replace MockPlistParser with FakePlistParser
- [flutter_tools] remove mockito from flutter symbolize test
- [flutter_tools] use TestFeatureFlags instead of MockFeatureFlags
- Adopt tool_test shard builders
flutter/cocoon 1 pull request
flutter/plugins 1 pull request
Opened 9 other issues in 1 repository
flutter/flutter
6
open
3
closed
- Metal crashes on engine roll
- Some iOS devicelab tests have been queued for ~3 hours
- "flutter run --use-application-binary" copies app to iOS device twice
- podhelper uses Ruby 2.5 syntax "Dir.each_child", minimum required is Ruby 2.0
- flutter_immediately_exit_test integration times out on Windows
- Flutter module with plugins requires "flutter build ios" in the module before being able to build for the simulator in host app
- HotRunner.attach NoSuchMethodError: The method 'map' was called on null
- Framework coverage is not uploaded anywhere
- flutter_gallery_win__compile failing on flutter-devicelab-windows-2 "Building with plugins requires symlink support"