Skip to content

/ plugins

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[video_player] Update video_player_web to point to new video_player_interface #3536

Merged
merged 1 commit into from Feb 13, 2021
Merged

[video_player] Update video_player_web to point to new video_player_interface #3536

merged 1 commit into from Feb 13, 2021
+7 −5

Conversation

@Hixie
Copy link
Member

@Hixie Hixie commented Feb 10, 2021 •
edited

This is a partial landing of #3281.

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.
@Hixie Hixie changed the title Update video_player_web to point to new video_player_interface [video_player] Update video_player_web to point to new video_player_interface Feb 10, 2021
@google-cla google-cla bot added the cla: yes label Feb 10, 2021
@Hixie Hixie force-pushed the Hixie:video_player_web_interface_update branch 2 times, most recently from 1d7eee4 to c21b645 Feb 11, 2021
@Hixie
Update video_player_web to point to new video_player_interface
Loading status checks…
bade0fa
@Hixie Hixie force-pushed the Hixie:video_player_web_interface_update branch from c21b645 to bade0fa Feb 13, 2021
@stuartmorgan
stuartmorgan approved these changes Feb 13, 2021
View changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

LGTM
@Hixie Hixie merged commit 10b40dd into flutter:master Feb 13, 2021
37 checks passed
37 checks passed
label
Details
post_merge_label
Details
WIP Ready for review
Details
Windows Plugins
Details
analyze CHANNEL:master Task Summary
Details
analyze CHANNEL:stable Task Summary
Details
build-apks+java-test+firebase-test-lab CHANNEL:master PLUGIN_SHARDING:--shardIndex 0 --shardCount 4 Task Summary
Details
build-apks+java-test+firebase-test-lab CHANNEL:master PLUGIN_SHARDING:--shardIndex 1 --shardCount 4 Task Summary
Details
build-apks+java-test+firebase-test-lab CHANNEL:master PLUGIN_SHARDING:--shardIndex 2 --shardCount 4 Task Summary
Details
build-apks+java-test+firebase-test-lab CHANNEL:master PLUGIN_SHARDING:--shardIndex 3 --shardCount 4 Task Summary
Details
build-apks+java-test+firebase-test-lab CHANNEL:stable PLUGIN_SHARDING:--shardIndex 0 --shardCount 4 Task Summary
Details
build-apks+java-test+firebase-test-lab CHANNEL:stable PLUGIN_SHARDING:--shardIndex 1 --shardCount 4 Task Summary
Details
build-apks+java-test+firebase-test-lab CHANNEL:stable PLUGIN_SHARDING:--shardIndex 2 --shardCount 4 Task Summary
Details
build-apks+java-test+firebase-test-lab CHANNEL:stable PLUGIN_SHARDING:--shardIndex 3 --shardCount 4 Task Summary
Details
build-apps+drive-examples Task Summary
Details
build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 0 --shardCount 4 Task Summary
Details
build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 1 --shardCount 4 Task Summary
Details
build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 2 --shardCount 4 Task Summary
Details
build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 3 --shardCount 4 Task Summary
Details
build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 0 --shardCount 4 Task Summary
Details
build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 1 --shardCount 4 Task Summary
Details
build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 2 --shardCount 4 Task Summary
Details
build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 3 --shardCount 4 Task Summary
Details
build-linux+drive-examples Task Summary
Details
build_all_plugins_apk CHANNEL:master Task Summary
Details
build_all_plugins_apk CHANNEL:stable Task Summary
Details
build_all_plugins_app Task Summary
Details
build_all_plugins_ipa CHANNEL:master Task Summary
Details
build_all_plugins_ipa CHANNEL:stable Task Summary
Details
cla/google All necessary CLAs are signed
format Task Summary
Details
lint_darwin_plugins PLUGIN_SHARDING:--shardIndex 0 --shardCount 2 Task Summary
Details
lint_darwin_plugins PLUGIN_SHARDING:--shardIndex 1 --shardCount 2 Task Summary
Details
publishable Task Summary
Details
submit-queue Ready to merge!
Details
test CHANNEL:master Task Summary
Details
test CHANNEL:stable Task Summary
Details
@Hixie Hixie deleted the Hixie:video_player_web_interface_update branch Feb 13, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 13, 2021
@engine-flutter-autoroll
10b40ddae Update video_player_web to point to new video_player_interf…
Loading status checks…
9342344 
…ace (flutter/plugins#3536)
pull bot pushed a commit to Mu-L/flutter that referenced this pull request Feb 13, 2021
@engine-flutter-autoroll
10b40ddae Update video_player_web to point to new video_player_interf…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
696e4f7 
…ace (flutter/plugins#3536) (flutter#75985)
ayaankhan98 added a commit to ayaankhan98/flutter that referenced this pull request Feb 14, 2021
@engine-flutter-autoroll @ayaankhan98
10b40ddae Update video_player_web to point to new video_player_interf…
Loading status checks…
848b7d4 
…ace (flutter/plugins#3536) (flutter#75985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan

Assignees
No one assigned
Labels
cla: yes p: video_player platform-web
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Hixie @stuartmorgan