Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-typography): strip typography properties #21878

Merged
merged 2 commits into from Feb 18, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Feb 11, 2021

with null value

This fixes an issue with MDC emitting CSS variables with no fallback value.

@mmalerba mmalerba added P2 G target: patch labels Feb 11, 2021
@google-cla google-cla bot added the cla: yes label Feb 11, 2021
Copy link
Member

@crisbeto crisbeto left a comment

LGTM

@crisbeto crisbeto added the merge ready label Feb 12, 2021
@andrewseguin andrewseguin merged commit 07eb0f7 into angular:master Feb 18, 2021
16 checks passed
andrewseguin pushed a commit that referenced this issue Feb 18, 2021
#21878)

* fix(material-experimental/mdc-typography): strip typography properties
with null value

* fixup! fix(material-experimental/mdc-typography): strip typography properties with null value

(cherry picked from commit 07eb0f7)
andrewseguin added a commit that referenced this issue Feb 19, 2021
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Mar 21, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes G merge ready P2 target: patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants