Skip to content

/ components Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-button): fix incomplete icon class targ… #21919

Merged
merged 1 commit into from Feb 18, 2021
Merged

fix(material-experimental/mdc-button): fix incomplete icon class targ… #21919

merged 1 commit into from Feb 18, 2021

Conversation

@annieyw
Copy link
Contributor

@annieyw annieyw commented Feb 16, 2021

…eting in styles

Fab styles only targeted mat-icon but the icon in a mdc-button can have material-icons class instead
@annieyw annieyw requested a review from andrewseguin Feb 16, 2021
@google-cla google-cla bot added the cla: yes label Feb 16, 2021
@annieyw
Copy link
Contributor Author

@annieyw annieyw commented Feb 16, 2021

FYI this change passes presubmit.
Also for the lint error can it just be suppressed or is directly targeting material-icons not the way to go?

crisbeto
crisbeto approved these changes Feb 16, 2021
View changes
Copy link
Member

@crisbeto crisbeto left a comment

LGTM. The lint rule for class names isn't super thorough so it doesn't resolve nested selectors. I think that you can safely disable it for the failing lines.

@annieyw
fix(material-experimental/mdc-button): fix incomplete icon class targ…
00e09d0 
…eting in styles
mmalerba
mmalerba approved these changes Feb 16, 2021
View changes
Copy link
Contributor

@mmalerba mmalerba left a comment

LGTM

@andrewseguin andrewseguin merged commit 334ae2a into angular:master Feb 18, 2021
16 checks passed
andrewseguin added a commit that referenced this issue Feb 18, 2021
@annieyw @andrewseguin
fix(material-experimental/mdc-button): fix incomplete icon class targ…
b18b483 
…eting in styles (#21919)

(cherry picked from commit 334ae2a)
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Mar 21, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto

@mmalerba mmalerba

@andrewseguin andrewseguin

@jelbourn jelbourn

@wagnermaciel wagnermaciel

Assignees
No one assigned
Labels
cla: yes G merge ready P3 target: patch
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@annieyw @crisbeto @mmalerba @andrewseguin