fix(material-experimental/mdc-button): add mdc ripple class for fab #21923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annieyw
added
P3
google-cla
bot
added
the
cla: yes
mmalerba
reviewed
Feb 16, 2021
| @@ -1,4 +1,4 @@ | |||
| <span class="mdc-button__ripple"></span> | |||
| <span class="mdc-button__ripple mdc-fab__ripple"></span> | |||
There was a problem hiding this comment.
should we conditionally apply these classes based on what type of button it is? i.e.
<span
[class.mdc-button__ripple]="!isFab"
[class.mdc-fab__ripple]="isFab">There was a problem hiding this comment.
added a _isFab property to button base
jelbourn
added
the
merge ready
mmalerba
added
P2
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
MDC button and MDC FAB are 2 different components but MDC based button and FAB share the same template.
Add
mdc-fab__rippleto the mdc-button ripple element to receive MDC's FAB ripple styles.