despo
Follow
Pinned
1,157 contributions in the last year
Less
More
Activity overview
Contributed to
DFE-Digital/apply-for-teacher-training,
codebar/planner,
despo/issuehub.io
and 5 other
repositories
Contribution activity
March 2021
Created 73 commits in 3 repositories
Created 1 repository
- despo/rubocop Ruby
Created a pull request in DFE-Digital/apply-for-teacher-training that received 2 comments
Opened 17 other pull requests in 2 repositories
DFE-Digital/apply-for-teacher-training
15
merged
1
closed
- Rails route helpers included in ViewComponent::Base
- Add reusable collection select component
- Remove unused helper methods
- Don’t attempt to sync courses when no provider can be found
- Restrict access to provider/interview controller
- Add reusable component for selecting provider
- Remove redundant view component configuration
- Remove unused views
- Add shared examples for year validations
- Add shared examples for month year validations
- Add missing work history break start_date validation
- Remove obsolete model
- Resolve erblint errors
- Add a new make offer service which wraps the old one
- Reorder validations, error is displayed in wrong position
- Add feature flag for new make offer flow
rubocop/rubocop
1
merged
Reviewed 30 pull requests in 2 repositories
DFE-Digital/apply-for-teacher-training 29 pull requests
- Adds `data:migrate` task
- Add caption and enable content block
- Humanize compared attribute
- Prevent users from being able to add new users to providers they don't have the right permissions for
- Rename service to change_an_offer
- Qualifications export - remove N+1 queries
- add delegators for accessing course option location details
- Remove V3 API (2/4) — sync subjects from public API, remove refs to V3
- Revert "Prevent application choices being added to application forms from previous recruitment cycles"
- Happy path for create the new make offer flow
- Add new permissions based query service for courses and providers
- Add reusable component for selecting a course.
- Bump view_component from 2.26.1 to 2.27.0
- Bump skylight from 4.3.2 to 5.0.0
- Fix Vendor API flakey tests
- Add shared examples for year validations
- Remove interview info from dashboard when cancelled
- Work history error messaging
- Update work history break export
- Display a helpful error if you attempt to make an offer on a course you dont run
- Add shared examples for month year validations
- Update restructured work history error messaging
- Display details of offered course
- Remove unused code
- Split First and Last name on application form view in Manage and Support
- Some pull request reviews not shown.