test: don't use --runInBand and improve execution performance (#2007)

backport from #2005 to master branch
webpack · Jun 10, 2019 · 4dec6b27b5f83f29899979528d565dff09040600 · 4dec6b2
1 parent 2b4cb52
commit 4dec6b27b5f83f29899979528d565dff09040600
diff --git a/.babelrc b/.babelrc
@@ -1,3 +1,8 @@
 {
-  "presets": ["@babel/preset-env"]
+  "presets": ["@babel/preset-env"],
+  "env": {
+    "test": {
+      "plugins": ["@babel/plugin-transform-runtime"]
+    }
+  }
 }
diff --git a/globalSetupTest.js b/globalSetupTest.js
@@ -0,0 +1,32 @@
+'use strict';
+
+// eslint-disable-next-line import/no-extraneous-dependencies
+const tcpPortUsed = require('tcp-port-used');
+const ports = require('./test/ports-map');
+
+async function validatePorts() {
+  const samples = [];
+
+  Object.keys(ports).forEach((key) => {
+    const value = ports[key];
+    const arr = Array.isArray(value) ? value : [value];
+
+    arr.forEach((port) => {
+      const check = tcpPortUsed.check(port, 'localhost').then((inUse) => {
+        if (inUse) throw new Error(`${port} has already used. [${key}]`);
+      });
+
+      samples.push(check);
+    });
+  });
+
+  try {
+    await Promise.all(samples);
+  } catch (e) {
+    // eslint-disable-next-line no-console
+    console.error(e);
+    process.exit(1);
+  }
+}
+
+module.exports = validatePorts;
diff --git a/jest.config.js b/jest.config.js
@@ -7,4 +7,5 @@ module.exports = {
   moduleFileExtensions: ['js', 'json'],
   testMatch: ['**/test/**/*.test.js'],
   setupFilesAfterEnv: ['<rootDir>/setupTest.js'],
+  globalSetup: '<rootDir>/globalSetupTest.js',
 };
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -19,7 +19,7 @@
     "lint": "npm-run-all -l -p \"lint:**\"",
     "commitlint": "commitlint --from=master",
     "security": "npm audit",
-    "test:only": "jest --runInBand",
+    "test:only": "jest",
     "test:coverage": "npm run test:only -- --coverage",
     "test:watch": "npm run test:coverage --watch",
     "test": "npm run test:coverage",
@@ -70,6 +70,7 @@
   "devDependencies": {
     "@babel/cli": "^7.4.4",
     "@babel/core": "^7.4.5",
+    "@babel/plugin-transform-runtime": "^7.4.4",
     "@babel/preset-env": "^7.4.5",
     "@commitlint/cli": "^7.6.1",
     "@commitlint/config-conventional": "^7.6.0",
@@ -102,6 +103,7 @@
     "standard-version": "^6.0.1",
     "style-loader": "^0.23.1",
     "supertest": "^4.0.2",
+    "tcp-port-used": "^1.0.1",
     "url-loader": "^1.1.2",
     "webpack": "^4.33.0",
     "webpack-cli": "^3.3.3",

diff --git a/test/cli/cli.test.js b/test/cli/cli.test.js
@@ -162,8 +162,10 @@ describe('CLI', () => {
     const cliPath = resolve(__dirname, '../../bin/webpack-dev-server.js');
     const examplePath = resolve(__dirname, '../../examples/cli/public');
 
-    const cp = execa('node', [cliPath], { cwd: examplePath });
-    const cp2 = execa('node', [cliPath], { cwd: examplePath });
+    const cp = execa('node', [cliPath, '--colors=false'], { cwd: examplePath });
+    const cp2 = execa('node', [cliPath, '--colors=false'], {
+      cwd: examplePath,
+    });
 
     const runtime = {
       cp: {

diff --git a/test/client/clients/SockJSClient.test.js b/test/client/clients/SockJSClient.test.js
@@ -4,6 +4,7 @@ const http = require('http');
 const express = require('express');
 const sockjs = require('sockjs');
 const SockJSClient = require('../../../client-src/clients/SockJSClient');
+const port = require('../../ports-map').sockJSClient;
 
 describe('SockJSClient', () => {
   let socketServer;
@@ -14,7 +15,7 @@ describe('SockJSClient', () => {
     const app = new express();
 
     listeningApp = http.createServer(app);
-    listeningApp.listen(8080, 'localhost', () => {
+    listeningApp.listen(port, 'localhost', () => {
       socketServer = sockjs.createServer();
       socketServer.installHandlers(listeningApp, {
         prefix: '/sockjs-node',
@@ -33,7 +34,7 @@ describe('SockJSClient', () => {
         }, 1000);
       });
 
-      const client = new SockJSClient('http://localhost:8080/sockjs-node');
+      const client = new SockJSClient(`http://localhost:${port}/sockjs-node`);
       const data = [];
 
       client.onOpen(() => {