Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
fix code sample in "Use Promises, not callbacks" section #211
Conversation
|
Thanks for looking into this! Apparently |
|
This change is very simple, if you can't do this change let me know early. |
| import { get } from 'request'; | ||
| import { writeFile } from 'fs'; | ||
| import { get } from 'request-promise'; | ||
| import { writeFile } from 'fs-promise'; |
felquis
Jul 16, 2017
Use fs-extra instead!
Use fs-extra instead!
|
Node 8 actually has a native solution for wrapping core APIs in promises. |
|
I don't see advantage using the built in promisify than using fs-extra. |
The advantage is one less dependency. |
I fixed package names in good code sample in "Use Promises, not callbacks" section.