benmccann
Follow
Pinned
2,657 contributions in the last year
Less
More
Activity overview
Contribution activity
March 2021
Created 62 commits in 10 repositories
Created 6 repositories
- benmccann/realworld-1 JavaScript
- benmccann/svite-1 Svelte
- benmccann/vite-plugin-svelte-1 JavaScript
- benmccann/vite-plugin-svelte Svelte
- benmccann/node-fetch JavaScript
- benmccann/kit JavaScript
Created a pull request in sveltejs/kit that received 9 comments
Delete duplicate copy of vite-plugin-svelte
Should we delete this one or this one the official home now that the repo has been opened up? We probably don't need two copies
+0
−1,025
•
9
comments
Opened 49 other pull requests in 13 repositories
sveltejs/kit
30
merged
1
open
4
closed
- Update realworld logo
- Update example READMEs
- Update realworld readme
- Fix adapter-vercel imports
- Add Vercel to list of adapters
- Option to disable client-side routing
- Headers cleanup
- Add some information about how to migrate integrations
- Add a couple code comments
- Upgrade Vite
- Update READMEs
- Remove duplicate pnpm-lock.yaml
- Remove outdated reference to Snowpack
- Add page titles to demo site
- Fix TODO for setting load error status
- Fix VS Code
- Fix two more type errors
- Fix error handling when thrown type is not Error
- Fix getSession examples
- Add ts-ignore to lines that should be ignored
- Fix paths in tsconfig.json
- Start on a migration guide
- Remove unused variable
- Update examples to use new redirect syntax
- Update docs to reflect that svelte-kit adapt no longer exists
- Some pull requests not shown.
chartjs/Chart.js
3
merged
gothinkster/realworld
1
open
sveltejs/realworld
1
merged
sveltejs/sapper
1
merged
sveltejs/svelte
1
merged
sveltejs/hn.svelte.dev
1
merged
svitejs/svite
1
closed
intrnl/vite-plugin-svelte
1
merged
sveltejs/vite-plugin-svelte
1
closed
sveltejs/integrations
1
merged
node-fetch/node-fetch
1
open
sveltejs/sites
1
closed
Reviewed 37 pull requests in 6 repositories
sveltejs/kit 30 pull requests
- replace setup with hooks
- Update adapter-vercel README.
- start to remove app utils
- allow first argument to fetch in load to be a Request
- Shrink client manifest
- Pass adapters directly to config
- prevent erroneous <style>undefined</style>
- Update READMEs
- Option to disable client-side routing
- start fleshing out migration guide
- make tests deterministic
- update docs
- Add page titles to demo site
- add out option to adapter-node, and add types for adapters
- .d.ts fixes
- Future-proof getSession
- Improve create-svelte types
- Future proof adapters
- A handful of type fixes
- include layout/error styles in SSR
- fix #354 test failure
- Service workers
- implement new redirect signature
- typecheck in CI
- Emit types
- Some pull request reviews not shown.
sveltejs/sapper-template 3 pull requests
sveltejs/sites 1 pull request
jtablesaw/tablesaw 1 pull request
sveltejs/sapper 1 pull request
vitejs/vite 1 pull request
Created an issue in sveltejs/kit that received 8 comments
Cloning of response leads to issues
This line: kit/packages/kit/src/runtime/server/page.js Line 128 in 8805c6d Causes issues in Node where it dies unexpectedly without any …
8
comments
Opened 17 other issues in 7 repositories
sveltejs/kit
4
open
6
closed
-
Tag every package with
latest - Vercel notification noise
- Type checking in adapters
- Provide a way for layouts to determine if current page is an error page
- FAQ
- Headers cleanup
- TypeScript template broken
- Don't include tsconfig.json in non-TypeScript projects
- Make body available in page
- lint is failing on master
svitejs/svite
2
closed
sveltejs/sapper-template
1
closed
sveltejs/vite-plugin-svelte
1
open
sveltejs/svelte
1
open
node-fetch/node-fetch
1
open
chartjs/Chart.js
1
closed
6
contributions
in private repositories
Mar 10 – Mar 24