Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump friendsofphp/php-cs-fixer from 2.18.3 to 2.18.5 in /vendor-bin/cs-fixer #4907

Conversation

@dependabot @github
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 7, 2021

Bumps friendsofphp/php-cs-fixer from 2.18.3 to 2.18.5.

Release notes

Sourced from friendsofphp/php-cs-fixer's releases.

v2.18.5 Remote Void

  • bug #5561 NoMixedEchoPrintFixer: fix for conditions without curly brackets (kubawerlos)
  • bug #5563 Priority fix: SingleSpaceAfterConstructFixer must run before BracesFixer (kubawerlos)
  • bug #5567 Fix order of BracesFixer and ClassDefinitionFixer (Daeroni)
  • bug #5596 NullableTypeTransformer - fix for attributes (kubawerlos, jrmajor)
  • bug #5598 GroupImportFixer - fix breaking code when fixing root classes (Leprechaunz)
  • minor #5571 DX: add test to make sure SingleSpaceAfterConstructFixer runs before FunctionDeclarationFixer (kubawerlos)
  • minor #5577 Extend priority test for "class_definition" vs "braces" (kubawerlos)
  • minor #5585 DX: make doc examples prettier (kubawerlos)
  • minor #5590 Docs: HeaderCommentFixer - document example how to remove header comment (keradus)
  • minor #5602 DX: regenerate docs (keradus)

v2.18.4 Remote Void

  • bug #4085 Priority: AlignMultilineComment should run before every PhpdocFixer (dmvdbrugge)
  • bug #5421 PsrAutoloadingFixer - Fix PSR autoloading outside configured directory (kelunik, keradus)
  • bug #5464 NativeFunctionInvocationFixer - PHP 8 attributes (HypeMC, keradus)
  • bug #5548 NullableTypeDeclarationForDefaultNullValueFixer - fix handling promoted properties (jrmajor, keradus)
  • bug #5550 TypeAlternationTransformer - fix for typed static properties (kubawerlos)
  • bug #5551 ClassAttributesSeparationFixer - fix for properties with type alternation (kubawerlos, keradus)
  • bug #5552 DX: test relation between function_declaration and method_argument_space (keradus)
  • minor #5540 DX: RuleSet - convert null handling to soft-warning (keradus)
  • minor #5545 DX: update checkbashisms (keradus)
Changelog

Sourced from friendsofphp/php-cs-fixer's changelog.

Changelog for v2.18.5

  • bug #5561 NoMixedEchoPrintFixer: fix for conditions without curly brackets (kubawerlos)
  • bug #5563 Priority fix: SingleSpaceAfterConstructFixer must run before BracesFixer (kubawerlos)
  • bug #5567 Fix order of BracesFixer and ClassDefinitionFixer (Daeroni)
  • bug #5596 NullableTypeTransformer - fix for attributes (kubawerlos, jrmajor)
  • bug #5598 GroupImportFixer - fix breaking code when fixing root classes (Leprechaunz)
  • minor #5571 DX: add test to make sure SingleSpaceAfterConstructFixer runs before FunctionDeclarationFixer (kubawerlos)
  • minor #5577 Extend priority test for "class_definition" vs "braces" (kubawerlos)
  • minor #5585 DX: make doc examples prettier (kubawerlos)
  • minor #5590 Docs: HeaderCommentFixer - document example how to remove header comment (keradus)
  • minor #5602 DX: regenerate docs (keradus)

Changelog for v2.18.4

  • bug #4085 Priority: AlignMultilineComment should run before every PhpdocFixer (dmvdbrugge)
  • bug #5421 PsrAutoloadingFixer - Fix PSR autoloading outside configured directory (kelunik, keradus)
  • bug #5464 NativeFunctionInvocationFixer - PHP 8 attributes (HypeMC, keradus)
  • bug #5548 NullableTypeDeclarationForDefaultNullValueFixer - fix handling promoted properties (jrmajor, keradus)
  • bug #5550 TypeAlternationTransformer - fix for typed static properties (kubawerlos)
  • bug #5551 ClassAttributesSeparationFixer - fix for properties with type alternation (kubawerlos, keradus)
  • bug #5552 DX: test relation between function_declaration and method_argument_space (keradus)
  • minor #5540 DX: RuleSet - convert null handling to soft-warning (keradus)
  • minor #5545 DX: update checkbashisms (keradus)
Commits
  • e0f6d05 prepared the 2.18.5 release
  • 8e8778b minor #5602 DX: regenerate docs (keradus)
  • 82cf209 DX: regenerate docs
  • 0d87d97 bug #5598 GroupImportFixer - fix breaking code when fixing root classes (Lepr...
  • 486b598 GroupImportFixer - fix breaking code when fixing root classes
  • 02675fc minor #5585 DX: make doc examples prettier (kubawerlos)
  • 23e5515 DX: make doc examples prettier
  • f01521b bug #5596 NullableTypeTransformer - fix for attributes (kubawerlos, jrmajor)
  • 86f5b39 Update tests/Fixer/Operator/TernaryToElvisOperatorFixerTest.php
  • e3f0d37 add test reproducing #5533
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps [friendsofphp/php-cs-fixer](https://github.com/FriendsOfPHP/PHP-CS-Fixer) from 2.18.3 to 2.18.5.
- [Release notes](https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases)
- [Changelog](https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/2.18/CHANGELOG.md)
- [Commits](FriendsOfPHP/PHP-CS-Fixer@v2.18.3...v2.18.5)

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Collaborator

@st3iny st3iny left a comment

FriendsOfPHP/PHP-CS-Fixer#5575 is still unresolved

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Apr 7, 2021

FriendsOfPHP/PHP-CS-Fixer#5575 is still unresolved

OTOH I'm not so sure anymore if that ticket is the regression in the .4 release. CI passes here 🤷

@st3iny
Copy link
Collaborator

@st3iny st3iny commented Apr 8, 2021

I'm not so sure anymore if that ticket is the regression in the .4 release. CI passes here

True. Let's merge this one.

@st3iny
st3iny approved these changes Apr 8, 2021
@ChristophWurst ChristophWurst merged commit 8f67916 into master Apr 8, 2021
31 checks passed
31 checks passed
build
Details
xml-linters
Details
Build release tarball
Details
Build release tarball
Details
Block fixup and squash commits
Details
Nextcloud dev-master
Details
Nextcloud stable20 php7.3 unit tests
Details
Nextcloud v20.0.4
Details
Nextcloud stable21 php7.3 unit tests
Details
Nextcloud master php7.3 unit tests
Details
Nextcloud stable20 php7.4 unit tests
Details
Nextcloud stable21 php7.4 unit tests
Details
Nextcloud master php7.4 unit tests
Details
php7.2 lint
Details
php7.4-sqlite integration tests
Details
php7.3 lint
Details
php7.4-mysql integration tests
Details
php7.4 lint
Details
php7.4-pgsql integration tests
Details
php8 lint
Details
php8-sqlite integration tests
Details
php8-mysql integration tests
Details
php8-pgsql integration tests
Details
php-cs check
Details
Front-end unit tests
Details
Nextcloud master app code check
Details
ESLint ESLint
Details
DCO DCO
Details
codecov/patch Coverage not affected when comparing b550749...168bbf7
Details
codecov/project 54.67% (+0.00%) compared to b550749
Details
fixupbot No fixup commits found. The commit history is clean 👍
Details
@ChristophWurst ChristophWurst deleted the dependabot/composer/vendor-bin/cs-fixer/friendsofphp/php-cs-fixer-2.18.5 branch Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants