Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item-specific toggles stay ticked and become invisible when said item is deleted from the build #105

Open
xkomachi opened this issue Jan 3, 2020 · 3 comments

Comments

@xkomachi
Copy link

@xkomachi xkomachi commented Jan 3, 2020

Repro steps:

  1. Add unique bow 'arborix' and equip it
  2. tick 'you have iron reflexes'
  3. delete arborix. you still gain armour instead of evasion from items. you cannot see the tickbox anymore
@LocalIdentity LocalIdentity added the bug label Jan 3, 2020
@pHiney
Copy link

@pHiney pHiney commented Jan 6, 2020

Just as a note, if you swap between weapon sets, the effect of 'you have iron reflexes' is removed, so there is code for adjusting this.

@pHiney
Copy link

@pHiney pHiney commented Jan 7, 2020

Bug probably exists for all items.

Add Augyre. change it's effect to ResTech and the problem exists for this item. (check saved .xml)

@pHiney
Copy link

@pHiney pHiney commented Jan 10, 2020

I have a fix for this but it comes with complications.
PoB appears not mean't to delete configuration option settings.
So my fix works correctly when the item is deleted. You can save and reopen the build and all will work as expected.
This fails in the following circumstances, before exiting the build and re opening it:

  • Ctrl-Z is used to bring the item back.
  • the item is re-added.

In these two circumstances, the configuration option for the item MAY appear to be set to it's previous value, but it isn't. Saving and reopening the build will reveal that the configuration option wasn't restored.

So if this complication is acceptable, I'll add a PR.

P

@LocalIdentity LocalIdentity added this to To do in 1.4.157.5 Update via automation Feb 15, 2020
@LocalIdentity LocalIdentity added this to To do in 1.4.157.7 Feb 26, 2020
@LocalIdentity LocalIdentity moved this from To do to In progress in 1.4.157.7 Feb 26, 2020
@ppoelzl ppoelzl pinned this issue Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1.4.157.7
  
In progress
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.