Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDashes in aliases #184
Dashes in aliases #184
Comments
|
While this is debatable, I think the choice has been made to follow linguistic convention here. Your three examples would in real life be written as:
As demonstrated, the underscore is used by gemoji to replace spaces. I'm not sure if this is done consistently, but it should be. Following linguistic rules does seem like the obvious way to go and thus I would argue we should not alter the dashes in those words. |
|
As for e-mail, there's also email alias without dash that has a different emoji variant. |
|
While I dislike the fact that gemoji uses both of them for different emoji, linguistically both the spelling of There is a possibility to eliminate the dashes from these names and adhere to linguistic standards, but it would include the following changes:
|
|
There's other emojis that use envelope, letter or mail aliases. The current |
|
I agree, this would be a good change and more in style with the symbols of the emoji. |
|
There is not a super-strong reason why gemoji would keep dashes in these aliases, but I guess the strongest reason right now would be backwards-compatibility. If we removed them from canonical I don't feel like there is a strong reason to eliminate dashes, however, so they are likely to say. Avoiding emoji collision in another app that supports additional emoticons such as |
|
I cannot say I fully agree with you on the usage issue, @mislav. Not because this is not true (because yes, in the end it is an issue with the way this library is being implemented and, as such, not per se an issue with the library itself), but because I feel like emoji like Personally I feel like adding aliases for the classic emoji should do the trick, but I am unsure how you feel about this (because this would mean |
|
@mislav what do you think about the email/envelope emojis? |
|
@xPaw I wasn't aware of |
There's a couple of aliases that use dashes instead of underscores:
t-rex,e-mail,non-potable_water,-1.Discord for example uses underscores for first three, and doesn't have
-1alias.In The Lounge typing
:-Pwould trigger our auto completion for non-potable_water, so for now I just replaced dashes to underscores (except for-1) which should probably be fine.Any reason for gemoji to keep dashes in these?