Set explicit password for pkcs 12 keystores #317
Closed
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously password was hardcoded to "changeit". The new -p12-password allows an explict password to be set. The same password is used for the keystore, and for the keypair.
This reverts commit 782bdea.
removed demo keystore
|
I discover this PR almost a year later, and would love to see it merged. |
|
Thank you, but as mentioned in #316 and https://pkg.go.dev/software.sslmate.com/src/go-pkcs12?utm_source=godoc#pkg-constants, PKCS#12 encryption is not at all robust, and exposing a way to set a password would give users the impression that it's safe to rely on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added one new command line flag:
If this is not set, behaviour is unchanged.