Fix build with LibreSSL 3.3.2 #5988
Merged
+10
−1
Conversation
While here, bump CI
DTLS_set_link_mtu and DTLS_get_link_min_mtu are not part of 3.3.2
|
Thanks! |
| #define CRYPTOGRAPHY_LIBRESSL_332_OR_GREATER \ | ||
| (LIBRESSL_VERSION_NUMBER >= 0x3030200f) |
Comment on lines
36
to
37
alex
Apr 19, 2021
Member
Please don't indent defines like this.
Please don't indent defines like this.
vishwin
Apr 19, 2021
Author
Contributor
I went by an older style from when we supported some older library versions, hopefully this is better.
I went by an older style from when we supported some older library versions, hopefully this is better.
| @@ -59,6 +66,8 @@ | |||
| static const int CRYPTOGRAPHY_NEEDS_OSRANDOM_ENGINE; | |||
| static const int CRYPTOGRAPHY_IS_LIBRESSL; | |||
| static const int CRYPTOGRAPHY_LIBRESSL_LESS_THAN_332; | |||
alex
Apr 19, 2021
Member
This can be removed, it's not actually used from Python.
This can be removed, it's not actually used from Python.
While here, fix indents
The variable is not actually used from Python
vishwin
added a commit
to vishwin/freebsd-ports
that referenced
this pull request
Apr 20, 2021
Merged upstream as pyca/cryptography#5988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
LibreSSL 3.3.2 added support for
SSL_OP_NO_DTLS*. Not opposed to usingLESS_THANinstead ofOR_GREATERfor the preprocessor guards.